From: Andrew Lunn <andrew@lunn•ch>
To: Michal Kubecek <mkubecek@suse•cz>
Cc: netdev@vger•kernel.org, Jakub Kicinski <kuba@kernel•org>,
davem@davemloft•net, thomas.lendacky@amd•com, benve@cisco•com,
_govind@gmx•com, pkaustub@cisco•com, peppe.cavallaro@st•com,
alexandre.torgue@st•com, joabreu@synopsys•com,
snelson@pensando•io, yisen.zhuang@huawei•com,
salil.mehta@huawei•com, jeffrey.t.kirsher@intel•com,
jacob.e.keller@intel•com, alexander.h.duyck@linux•intel.com,
michael.chan@broadcom•com, saeedm@mellanox•com, leon@kernel•org
Subject: Re: [PATCH net-next 01/12] ethtool: add infrastructure for centralized checking of coalescing parameters
Date: Wed, 4 Mar 2020 16:22:49 +0100 [thread overview]
Message-ID: <20200304152249.GD3553@lunn.ch> (raw)
In-Reply-To: <20200304151958.GI4264@unicorn.suse.cz>
On Wed, Mar 04, 2020 at 04:19:58PM +0100, Michal Kubecek wrote:
> On Wed, Mar 04, 2020 at 03:54:39PM +0100, Andrew Lunn wrote:
> > On Tue, Mar 03, 2020 at 07:54:50PM -0800, Jakub Kicinski wrote:
> > > @@ -2336,6 +2394,11 @@ ethtool_set_per_queue_coalesce(struct net_device *dev,
> > > goto roll_back;
> > > }
> > >
> > > + if (!ethtool_set_coalesce_supported(dev, &coalesce)) {
> > > + ret = -EINVAL;
> > > + goto roll_back;
> > > + }
> >
> > Hi Jakub
> >
> > EOPNOTSUPP?
>
> Out of the 11 drivers patched in the rest of the series, 4 used
> EOPNOTSUPP, 3 EINVAL and 4 just ignored unsupported parameters so there
> doesn't seem to be a clear consensus. Personally I find EOPNOTSUPP more
> appropriate but it's quite common that drivers return EINVAL for
> parameters they don't understand or support.
Hi Michel
Yes, as i looked through the later patches, it became clear there is
no consensus. I personally prefer EOPNOTSUPP, but don't care too much.
Andrew
next prev parent reply other threads:[~2020-03-04 15:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 3:54 [PATCH net-next 00/12] ethtool: consolidate parameter checking for irq coalescing Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 01/12] ethtool: add infrastructure for centralized checking of coalescing parameters Jakub Kicinski
2020-03-04 14:54 ` Andrew Lunn
2020-03-04 15:19 ` Michal Kubecek
2020-03-04 15:22 ` Andrew Lunn [this message]
2020-03-04 18:11 ` Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 02/12] xgbe: let core reject the unsupported " Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 03/12] enic: " Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 04/12] stmmac: " Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 05/12] nfp: " Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 06/12] ionic: " Jakub Kicinski
2020-03-04 4:22 ` Shannon Nelson
2020-03-04 3:54 ` [PATCH net-next 07/12] hisilicon: " Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 08/12] ice: " Jakub Kicinski
2020-03-04 4:24 ` Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 09/12] bnxt: reject unsupported coalescing params Jakub Kicinski
2020-03-04 3:54 ` [PATCH net-next 10/12] mlx5: " Jakub Kicinski
2020-03-04 3:55 ` [PATCH net-next 11/12] e1000e: " Jakub Kicinski
2020-03-04 3:55 ` [PATCH net-next 12/12] virtio_net: " Jakub Kicinski
2020-03-04 4:07 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304152249.GD3553@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=_govind@gmx$(echo .)com \
--cc=alexander.h.duyck@linux$(echo .)intel.com \
--cc=alexandre.torgue@st$(echo .)com \
--cc=benve@cisco$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=pkaustub@cisco$(echo .)com \
--cc=saeedm@mellanox$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=snelson@pensando$(echo .)io \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox