Subject: Re: [PATCH net-next 3/3] bareudp: remove unnecessary udp_encap_enable() in bareudp_socket_create()

From: Martin Varghese <[email-masked]>
Date: Mon, 9 Mar 2020 11:33:04 +0530

On Sun, Mar 08, 2020 at 01:19:30AM +0000, Taehee Yoo wrote:
> In the current code, udp_encap_enable() is called in
> bareudp_socket_create().
> But, setup_udp_tunnel_sock() internally calls udp_encap_enable().
> So, udp_encap_enable() is unnecessary.
> 
> Signed-off-by: Taehee Yoo <[email-masked]>
> ---
>  drivers/net/bareudp.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c
> index c9d0d68467f7..71a2f480f70e 100644
> --- a/drivers/net/bareudp.c
> +++ b/drivers/net/bareudp.c
> @@ -250,9 +250,6 @@ static int bareudp_socket_create(struct bareudp_dev *bareudp, __be16 port)
>  	tunnel_cfg.encap_destroy = NULL;
>  	setup_udp_tunnel_sock(bareudp->net, sock, &tunnel_cfg);
>  
> -	if (sock->sk->sk_family == AF_INET6)
> -		udp_encap_enable();
> -
udp_encap_enable is not called for V6 sockets so we need to have the above lines of code 
>  	rcu_assign_pointer(bareudp->sock, sock);
>  	return 0;
>  }
> -- 
> 2.17.1
>