Subject: Re: [PATCH] net: phy: at803x: select correct page on initialization

From: Andrew Lunn <[email-masked]>
Date: Mon, 23 Mar 2020 22:11:50 +0100

On Mon, Mar 23, 2020 at 10:08:49PM +0100, David Bauer wrote:
> Hello Andrew,
> 
> On 3/23/20 5:53 PM, Andrew Lunn wrote:
> > You might want to look at phy_read_paged(), phy_write_paged(), etc,
> > depending on your needs. There can be locking issues, which these
> > functions address.
> 
> Thanks for the hint, i was not aware of these methods. I see how they can handle
> e.g. the page-switching logic in phy_read_paged.
> 
> However i still need to select the copper page on config initialization manually,
> as genphy_update_link is not page aware or am i missing something here?

Hi David

Yes, for that initial setup, you need to directly write to the
register. But at803x_aneg_done() should use these helpers.

	  Andrew