From: Jiri Olsa <jolsa@redhat•com>
To: Ian Rogers <irogers@google•com>
Cc: Peter Zijlstra <peterz@infradead•org>,
Ingo Molnar <mingo@redhat•com>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
Mark Rutland <mark.rutland@arm•com>,
Alexander Shishkin <alexander.shishkin@linux•intel.com>,
Namhyung Kim <namhyung@kernel•org>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Martin KaFai Lau <kafai@fb•com>, Yonghong Song <yhs@fb•com>,
Andrii Nakryiko <andriin@fb•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Thomas Gleixner <tglx@linutronix•de>,
Igor Lubashev <ilubashe@akamai•com>,
Alexey Budankov <alexey.budankov@linux•intel.com>,
Florian Fainelli <f.fainelli@gmail•com>,
Adrian Hunter <adrian.hunter@intel•com>,
Andi Kleen <ak@linux•intel.com>,
Jiwei Sun <jiwei.sun@windriver•com>,
yuzhoujian <yuzhoujian@didichuxing•com>,
Kan Liang <kan.liang@linux•intel.com>,
Jin Yao <yao.jin@linux•intel.com>, Leo Yan <leo.yan@linaro•org>,
John Garry <john.garry@huawei•com>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
bpf@vger•kernel.org, linux-perf-users@vger•kernel.org,
Stephane Eranian <eranian@google•com>
Subject: Re: [PATCH v5] perf tools: add support for libpfm4
Date: Tue, 24 Mar 2020 11:25:28 +0100 [thread overview]
Message-ID: <20200324102528.GM1534489@krava> (raw)
In-Reply-To: <20200323235846.104937-1-irogers@google.com>
On Mon, Mar 23, 2020 at 04:58:46PM -0700, Ian Rogers wrote:
SNIP
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 616fbda7c3fc..11421f5dc9cb 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -869,6 +869,17 @@ static struct perf_pmu *pmu_find(const char *name)
> return NULL;
> }
>
> +struct perf_pmu *perf_pmu__find_by_type(unsigned int type)
> +{
> + struct perf_pmu *pmu;
> +
> + list_for_each_entry(pmu, &pmus, list)
> + if (pmu->type == type)
> + return pmu;
> +
> + return NULL;
> +}
please move this to separate patch
thanks,
jirka
> +
> struct perf_pmu *perf_pmu__scan(struct perf_pmu *pmu)
> {
> /*
> diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
> index 5fb3f16828df..de3b868d912c 100644
> --- a/tools/perf/util/pmu.h
> +++ b/tools/perf/util/pmu.h
> @@ -65,6 +65,7 @@ struct perf_pmu_alias {
> };
>
> struct perf_pmu *perf_pmu__find(const char *name);
> +struct perf_pmu *perf_pmu__find_by_type(unsigned int type);
> int perf_pmu__config(struct perf_pmu *pmu, struct perf_event_attr *attr,
> struct list_head *head_terms,
> struct parse_events_error *error);
> --
> 2.25.1.696.g5e7596f4ac-goog
>
next prev parent reply other threads:[~2020-03-24 10:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 23:58 [PATCH v5] perf tools: add support for libpfm4 Ian Rogers
2020-03-24 10:24 ` Jiri Olsa
2020-03-24 10:25 ` Jiri Olsa [this message]
2020-03-24 10:25 ` Jiri Olsa
2020-03-24 10:26 ` Jiri Olsa
2020-03-24 10:26 ` Jiri Olsa
2020-03-24 10:27 ` Jiri Olsa
2020-03-24 10:27 ` Jiri Olsa
2020-03-24 15:29 ` Ian Rogers
2020-04-07 6:43 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324102528.GM1534489@krava \
--to=jolsa@redhat$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=ak@linux$(echo .)intel.com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=alexey.budankov@linux$(echo .)intel.com \
--cc=andriin@fb$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=eranian@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=ilubashe@akamai$(echo .)com \
--cc=irogers@google$(echo .)com \
--cc=jiwei.sun@windriver$(echo .)com \
--cc=john.garry@huawei$(echo .)com \
--cc=kafai@fb$(echo .)com \
--cc=kan.liang@linux$(echo .)intel.com \
--cc=leo.yan@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=yao.jin@linux$(echo .)intel.com \
--cc=yhs@fb$(echo .)com \
--cc=yuzhoujian@didichuxing$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox