From: "Michael S. Tsirkin" <mst@redhat•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: "linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Ard Biesheuvel <ardb@kernel•org>,
"richard.henderson@linaro•org" <richard.henderson@linaro•org>,
"christophe.lyon@st•com" <christophe.lyon@st•com>,
kbuild test robot <lkp@intel•com>,
"daniel.santos@pobox•com" <daniel.santos@pobox•com>,
Jason Wang <jasowang@redhat•com>,
"kbuild-all@lists•01.org" <kbuild-all@lists•01.org>,
Russell King <rmk+kernel@armlinux•org.uk>,
Linux ARM <linux-arm-kernel@lists•infradead.org>,
Richard Earnshaw <Richard.Earnshaw@arm•com>,
Sudeep Dutt <sudeep.dutt@intel•com>,
Ashutosh Dixit <ashutosh.dixit@intel•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"David S. Miller" <davem@davemloft•net>,
Networking <netdev@vger•kernel.org>,
virtualization@lists•linux-foundation.org,
kvm list <kvm@vger•kernel.org>
Subject: Re: [PATCH v2 2/2] vhost: disable for OABI
Date: Mon, 6 Apr 2020 09:02:02 -0400 [thread overview]
Message-ID: <20200406085707-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAK8P3a1nce31itwMKbmXoNZh-Y68m3GX_WwzNiaBuk280VFh-Q@mail.gmail.com>
On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote:
> On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin <mst@redhat•com> wrote:
>
> >
> > +config VHOST_DPN
> > + bool "VHOST dependencies"
> > + depends on !ARM || AEABI
> > + default y
> > + help
> > + Anything selecting VHOST or VHOST_RING must depend on VHOST_DPN.
> > + This excludes the deprecated ARM ABI since that forces a 4 byte
> > + alignment on all structs - incompatible with virtio spec requirements.
> > +
>
> This should not be a user-visible option, so just make this 'def_bool
> !ARM || AEABI'
>
> Arnd
I like keeping some kind of hint around for when one tries to understand
why is a specific symbol visible.
--
MST
next prev parent reply other threads:[~2020-04-06 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200406121233.109889-1-mst@redhat.com>
2020-04-06 12:12 ` [PATCH v2 2/2] vhost: disable for OABI Michael S. Tsirkin
2020-04-06 12:45 ` Ard Biesheuvel
2020-04-06 12:56 ` Michael S. Tsirkin
2020-04-06 12:50 ` Arnd Bergmann
2020-04-06 13:02 ` Michael S. Tsirkin [this message]
2020-04-06 13:15 ` Arnd Bergmann
2020-04-06 13:21 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406085707-mutt-send-email-mst@kernel.org \
--to=mst@redhat$(echo .)com \
--cc=Richard.Earnshaw@arm$(echo .)com \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=ashutosh.dixit@intel$(echo .)com \
--cc=christophe.lyon@st$(echo .)com \
--cc=daniel.santos@pobox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jasowang@redhat$(echo .)com \
--cc=kbuild-all@lists$(echo .)01.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lkp@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richard.henderson@linaro$(echo .)org \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=sudeep.dutt@intel$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox