From: Borislav Petkov <bp@suse•de>
To: Leon Romanovsky <leon@kernel•org>
Cc: "David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Leon Romanovsky <leonro@mellanox•com>,
Andy Gospodarek <andy@greyhouse•net>,
Ion Badulescu <ionut@badula•org>,
Jay Vosburgh <j.vosburgh@gmail•com>,
linux-pm@vger•kernel.org, netdev@vger•kernel.org,
Pensando Drivers <drivers@pensando•io>,
Sebastian Reichel <sre@kernel•org>,
Shannon Nelson <snelson@pensando•io>,
Veaceslav Falico <vfalico@gmail•com>
Subject: Re: [PATCH net-next 1/4] drivers: Remove inclusion of vermagic header
Date: Tue, 14 Apr 2020 18:00:41 +0200 [thread overview]
Message-ID: <20200414160041.GG31763@zn.tnic> (raw)
In-Reply-To: <20200414155732.1236944-2-leon@kernel.org>
On Tue, Apr 14, 2020 at 06:57:29PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox•com>
>
> Get rid of linux/vermagic.h includes, so that MODULE_ARCH_VERMAGIC from
> the arch header arch/x86/include/asm/module.h won't be redefined.
>
> In file included from ./include/linux/module.h:30,
> from drivers/net/ethernet/3com/3c515.c:56:
> ./arch/x86/include/asm/module.h:73: warning: "MODULE_ARCH_VERMAGIC"
> redefined
> 73 | # define MODULE_ARCH_VERMAGIC MODULE_PROC_FAMILY
> |
> In file included from drivers/net/ethernet/3com/3c515.c:25:
> ./include/linux/vermagic.h:28: note: this is the location of the
> previous definition
> 28 | #define MODULE_ARCH_VERMAGIC ""
> |
>
> Fixes: 6bba2e89a88c ("net/3com: Delete driver and module versions from 3com drivers")
> Signed-off-by: Borislav Petkov <bp@suse•de>
Just my SOB like that doesn't mean anything. You should add
Co-developed-by: me
Signed-off-by: me
if you want to state that we both worked on this fix.
Thx.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
next prev parent reply other threads:[~2020-04-14 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 15:57 [PATCH net-next 0/4] Remove vermagic header from global include folder Leon Romanovsky
2020-04-14 15:57 ` [PATCH net-next 1/4] drivers: Remove inclusion of vermagic header Leon Romanovsky
2020-04-14 16:00 ` Borislav Petkov [this message]
2020-04-14 17:26 ` Leon Romanovsky
2020-04-14 17:44 ` Borislav Petkov
2020-04-14 17:54 ` Leon Romanovsky
2020-04-14 17:07 ` Sebastian Reichel
2020-04-14 17:32 ` Shannon Nelson
2020-04-14 17:45 ` Borislav Petkov
2020-04-14 15:57 ` [PATCH net-next 2/4] net/hns: Remove custom driver version in favour of global one Leon Romanovsky
2020-04-14 15:57 ` [PATCH net-next 3/4] net/nfp: Update driver to use global kernel version Leon Romanovsky
2020-04-14 20:37 ` Jakub Kicinski
[not found] ` <20200414155732.1236944-5-leon@kernel.org>
[not found] ` <20200414160349.GH31763@zn.tnic>
2020-04-14 18:41 ` [PATCH net-next 4/4] kernel/module: Hide vermagic header file from general use Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414160041.GG31763@zn.tnic \
--to=bp@suse$(echo .)de \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=drivers@pensando$(echo .)io \
--cc=ionut@badula$(echo .)org \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=leonro@mellanox$(echo .)com \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=snelson@pensando$(echo .)io \
--cc=sre@kernel$(echo .)org \
--cc=vfalico@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox