From: Jiri Olsa <jolsa@redhat•com>
To: Ian Rogers <irogers@google•com>
Cc: Peter Zijlstra <peterz@infradead•org>,
Ingo Molnar <mingo@redhat•com>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
Mark Rutland <mark.rutland@arm•com>,
Alexander Shishkin <alexander.shishkin@linux•intel.com>,
Namhyung Kim <namhyung@kernel•org>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Martin KaFai Lau <kafai@fb•com>, Yonghong Song <yhs@fb•com>,
Andrii Nakryiko <andriin@fb•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Thomas Gleixner <tglx@linutronix•de>,
Igor Lubashev <ilubashe@akamai•com>,
Alexey Budankov <alexey.budankov@linux•intel.com>,
Florian Fainelli <f.fainelli@gmail•com>,
Adrian Hunter <adrian.hunter@intel•com>,
Andi Kleen <ak@linux•intel.com>,
Jiwei Sun <jiwei.sun@windriver•com>,
yuzhoujian <yuzhoujian@didichuxing•com>,
Kan Liang <kan.liang@linux•intel.com>,
Jin Yao <yao.jin@linux•intel.com>, Leo Yan <leo.yan@linaro•org>,
John Garry <john.garry@huawei•com>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
bpf@vger•kernel.org, linux-perf-users@vger•kernel.org,
Stephane Eranian <eranian@google•com>
Subject: Re: [PATCH v9 4/4] perf tools: add support for libpfm4
Date: Thu, 16 Apr 2020 11:55:48 +0200 [thread overview]
Message-ID: <20200416095548.GD369437@krava> (raw)
In-Reply-To: <20200416063551.47637-5-irogers@google.com>
On Wed, Apr 15, 2020 at 11:35:51PM -0700, Ian Rogers wrote:
SNIP
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 1ab349abe904..80ac598f125b 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -43,6 +43,7 @@
> #include "util/time-utils.h"
> #include "util/units.h"
> #include "util/bpf-event.h"
> +#include "util/pfm.h"
> #include "asm/bug.h"
> #include "perf.h"
>
> @@ -64,6 +65,9 @@
> #include <linux/zalloc.h>
> #include <linux/bitmap.h>
>
> +
> +
> +
extra new lines..
jirka
> struct switch_output {
> bool enabled;
> bool signal;
> @@ -2421,6 +2425,11 @@ static struct option __record_options[] = {
> #endif
> OPT_CALLBACK(0, "max-size", &record.output_max_size,
> "size", "Limit the maximum size of the output file", parse_output_max_size),
> +#ifdef HAVE_LIBPFM
> + OPT_CALLBACK(0, "pfm-events", &record.evlist, "event",
> + "libpfm4 event selector. use 'perf list' to list available events",
> + parse_libpfm_events_option),
> +#endif
> OPT_END()
> };
SNIP
next prev parent reply other threads:[~2020-04-16 9:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 6:35 [PATCH v9 0/4] perf tools: add support for libpfm4 Ian Rogers
2020-04-16 6:35 ` [PATCH v9 1/4] perf doc: allow ASCIIDOC_EXTRA to be an argument Ian Rogers
2020-04-16 6:35 ` [PATCH v9 2/4] tools feature: add support for detecting libpfm4 Ian Rogers
2020-04-16 6:35 ` [PATCH v9 3/4] perf pmu: add perf_pmu__find_by_type helper Ian Rogers
2020-04-16 6:35 ` [PATCH v9 4/4] perf tools: add support for libpfm4 Ian Rogers
2020-04-16 9:50 ` Jiri Olsa
2020-04-16 9:55 ` Jiri Olsa
2020-04-16 16:02 ` Ian Rogers
2020-04-16 20:10 ` Jiri Olsa
2020-04-16 22:19 ` Ian Rogers
2020-04-16 9:55 ` Jiri Olsa [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-14 18:10 [PATCH v9 0/4] " Ian Rogers
2020-04-14 18:10 ` [PATCH v9 4/4] " Ian Rogers
2020-04-14 18:04 [PATCH v9 0/4] " Ian Rogers
2020-04-14 18:04 ` [PATCH v9 4/4] " Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416095548.GD369437@krava \
--to=jolsa@redhat$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=ak@linux$(echo .)intel.com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=alexey.budankov@linux$(echo .)intel.com \
--cc=andriin@fb$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=eranian@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=ilubashe@akamai$(echo .)com \
--cc=irogers@google$(echo .)com \
--cc=jiwei.sun@windriver$(echo .)com \
--cc=john.garry@huawei$(echo .)com \
--cc=kafai@fb$(echo .)com \
--cc=kan.liang@linux$(echo .)intel.com \
--cc=leo.yan@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=yao.jin@linux$(echo .)intel.com \
--cc=yhs@fb$(echo .)com \
--cc=yuzhoujian@didichuxing$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox