From: Andrew Lunn <andrew@lunn•ch>
To: Russell King - ARM Linux admin <linux@armlinux•org.uk>
Cc: Oleksij Rempel <o.rempel@pengutronix•de>,
"David S. Miller" <davem@davemloft•net>,
Florian Fainelli <f.fainelli@gmail•com>,
Heiner Kallweit <hkallweit1@gmail•com>,
Jakub Kicinski <kuba@kernel•org>,
Jonathan Corbet <corbet@lwn•net>,
Michal Kubecek <mkubecek@suse•cz>,
David Jander <david@protonic•nl>,
kernel@pengutronix•de, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, mkl@pengutronix•de
Subject: Re: [PATCH v1] ethtool: provide UAPI for PHY master/slave configuration.
Date: Fri, 17 Apr 2020 16:32:39 +0200 [thread overview]
Message-ID: <20200417143239.GH744226@lunn.ch> (raw)
In-Reply-To: <20200417101145.GP25745@shell.armlinux.org.uk>
On Fri, Apr 17, 2020 at 11:11:45AM +0100, Russell King - ARM Linux admin wrote:
> On Wed, Apr 15, 2020 at 11:57:39PM +0200, Andrew Lunn wrote:
> > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> > > index c8b0c34030d32..d5edf2bc40e43 100644
> > > --- a/drivers/net/phy/phy_device.c
> > > +++ b/drivers/net/phy/phy_device.c
> > > @@ -604,6 +604,7 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, u32 phy_id,
> > > dev->asym_pause = 0;
> > > dev->link = 0;
> > > dev->interface = PHY_INTERFACE_MODE_GMII;
> > > + dev->master_slave = PORT_MODE_UNKNOWN;
> >
> > phydev->master_slave is how we want the PHY to be configured. I don't
> > think PORT_MODE_UNKNOWN makes any sense in that contest. 802.3 gives
> > some defaults. 9.12 should be 0, meaning manual master/slave
> > configuration is disabled. The majority of linux devices are end
> > systems. So we should default to a single point device. So i would
> > initialise PORT_MODE_SLAVE, or whatever we end up calling that.
>
> I'm not sure that is a good idea given that we use phylib to drive
> the built-in PHYs in DSA switches, which ought to prefer master mode
> via the "is a multiport device" bit.
O.K. So i assume you mean we should read from the PHY at probe time
what it is doing, in order to initialise dev->master_slave?
I would be happy with that.
Andrew
next prev parent reply other threads:[~2020-04-17 14:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 12:12 [PATCH v1] ethtool: provide UAPI for PHY master/slave configuration Oleksij Rempel
2020-04-15 12:19 ` Oleksij Rempel
2020-04-15 12:43 ` Michal Kubecek
2020-04-15 13:00 ` Oleksij Rempel
2020-04-15 14:14 ` Russell King - ARM Linux admin
2020-04-15 13:08 ` Oleksij Rempel
2020-04-15 13:11 ` Andrew Lunn
2020-04-15 13:37 ` Oleksij Rempel
2020-04-15 13:45 ` Andrew Lunn
2020-04-17 6:48 ` [EXT] " Christian Herber
2020-04-15 21:57 ` Andrew Lunn
2020-04-17 10:11 ` Russell King - ARM Linux admin
2020-04-17 11:28 ` Oleksij Rempel
2020-04-17 11:51 ` Russell King - ARM Linux admin
2020-04-17 14:32 ` Andrew Lunn [this message]
2020-04-17 14:35 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417143239.GH744226@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=david@protonic$(echo .)nl \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mkl@pengutronix$(echo .)de \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=o.rempel@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox