From: Andrew Lunn <andrew@lunn•ch>
To: Michael Walle <michael@walle•cc>
Cc: linux-hwmon@vger•kernel.org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, Jean Delvare <jdelvare@suse•com>,
Guenter Roeck <linux@roeck-us•net>,
Florian Fainelli <f.fainelli@gmail•com>,
Heiner Kallweit <hkallweit1@gmail•com>,
Russell King <linux@armlinux•org.uk>,
"David S . Miller" <davem@davemloft•net>
Subject: Re: [PATCH net-next v3 2/3] net: phy: add Broadcom BCM54140 support
Date: Mon, 20 Apr 2020 21:57:41 +0200 [thread overview]
Message-ID: <20200420195741.GG917792@lunn.ch> (raw)
In-Reply-To: <20200420182113.22577-2-michael@walle.cc>
On Mon, Apr 20, 2020 at 08:21:12PM +0200, Michael Walle wrote:
> The Broadcom BCM54140 is a Quad SGMII/QSGMII Copper/Fiber Gigabit
> Ethernet transceiver.
>
> This also adds support for tunables to set and get downshift and
> energy detect auto power-down.
>
> The PHY has four ports and each port has its own PHY address.
> There are per-port registers as well as global registers.
> Unfortunately, the global registers can only be accessed by reading
> and writing from/to the PHY address of the first port. Further,
> there is no way to find out what port you actually are by just
> reading the per-port registers. We therefore, have to scan the
> bus on the PHY probe to determine the port and thus what address
> we need to access the global registers.
>
> Signed-off-by: Michael Walle <michael@walle•cc>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2020-04-20 19:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 18:21 [PATCH net-next v3 1/3] net: phy: broadcom: add helper to write/read RDB registers Michael Walle
2020-04-20 18:21 ` [PATCH net-next v3 2/3] net: phy: add Broadcom BCM54140 support Michael Walle
2020-04-20 19:57 ` Andrew Lunn [this message]
2020-04-22 19:15 ` David Miller
2020-04-20 18:21 ` [PATCH net-next v3 3/3] net: phy: bcm54140: add hwmon support Michael Walle
2020-04-20 19:58 ` Andrew Lunn
2020-04-22 19:15 ` David Miller
2020-04-22 19:15 ` [PATCH net-next v3 1/3] net: phy: broadcom: add helper to write/read RDB registers David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420195741.GG917792@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jdelvare@suse$(echo .)com \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linux@roeck-us$(echo .)net \
--cc=michael@walle$(echo .)cc \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox