Subject: Re: [PATCH net-next 2/2] dpaa2-eth: fix return codes used in ndo_setup_tc

From: Jesper Dangaard Brouer <[email-masked]>
Date: Thu, 23 Apr 2020 17:38:04 +0200

On Thu, 23 Apr 2020 08:28:58 -0700
Stephen Hemminger <[email-masked]> wrote:

> On Thu, 23 Apr 2020 16:57:50 +0200
> Jesper Dangaard Brouer <[email-masked]> wrote:
> 
> > Drivers ndo_setup_tc call should return -EOPNOTSUPP, when it cannot
> > support the qdisc type. Other return values will result in failing the
> > qdisc setup.  This lead to qdisc noop getting assigned, which will
> > drop all TX packets on the interface.
> > 
> > Fixes: ab1e6de2bd49 ("dpaa2-eth: Add mqprio support")
> > Signed-off-by: Jesper Dangaard Brouer <[email-masked]>  
> 
> Would it be possible to use extack as well?

That is what patch 1/2 already does.

> Putting errors in dmesg is unhelpful

This patchset does not introduce any dmesg printk.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer