From: Vincent Cheng <vincent.cheng.xh@renesas•com>
To: Yang Yingliang <yangyingliang@huawei•com>
Cc: richardcochran@gmail•com, davem@davemloft•net,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison
Date: Fri, 24 Apr 2020 09:22:34 -0400 [thread overview]
Message-ID: <20200424132233.GA18127@renesas.com> (raw)
In-Reply-To: <1587732746-98057-1-git-send-email-yangyingliang@huawei.com>
>Reported-by: Hulk Robot <hulkci@huawei•com>
>Signed-off-by: Yang Yingliang <yangyingliang@huawei•com>
>---
> drivers/ptp/ptp_clockmatrix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
>index 032e112..56aee4f 100644
>--- a/drivers/ptp/ptp_clockmatrix.c
>+++ b/drivers/ptp/ptp_clockmatrix.c
>@@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
>
> /* Page size 128, last 4 bytes of page skipped */
> if (((loaddr > 0x7b) && (loaddr <= 0x7f))
>- || ((loaddr > 0xfb) && (loaddr <= 0xff)))
>+ || loaddr > 0xfb)
> continue;
>
> err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val));
Thank-you for the fix.
Reviewed-by: Vincent Cheng <vincent.cheng.xh@renesas•com>
next prev parent reply other threads:[~2020-04-24 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 12:52 [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison Yang Yingliang
2020-04-24 13:22 ` Vincent Cheng [this message]
2020-04-26 3:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424132233.GA18127@renesas.com \
--to=vincent.cheng.xh@renesas$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richardcochran@gmail$(echo .)com \
--cc=yangyingliang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox