From: Kalle Valo <kvalo@codeaurora•org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Cc: "Arend van Spriel" <arend.vanspriel@broadcom•com>,
"Franky Lin" <franky.lin@broadcom•com>,
"Hante Meuleman" <hante.meuleman@broadcom•com>,
"Chi-Hsien Lin" <chi-hsien.lin@cypress•com>,
"Wright Feng" <wright.feng@cypress•com>,
"David S. Miller" <davem@davemloft•net>,
"Pieter-Paul Giesberts" <pieter-paul.giesberts@broadcom•com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Rafał Miłecki" <rafal@milecki•pl>,
linux-wireless@vger•kernel.org,
brcm80211-dev-list.pdl@broadcom•com,
brcm80211-dev-list@cypress•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] brcmfmac: no need to check return value of debugfs_create functions
Date: Mon, 4 May 2020 09:50:42 +0000 (UTC) [thread overview]
Message-ID: <20200504095042.4289CC432C2@smtp.codeaurora.org> (raw)
In-Reply-To: <20200429101526.GA2094124@kroah.com>
Greg Kroah-Hartman <gregkh@linuxfoundation•org> wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> In doing this, make brcmf_debugfs_add_entry() return void as no one was
> even paying attention to the return value.
>
> Cc: Arend van Spriel <arend.vanspriel@broadcom•com>
> Cc: Franky Lin <franky.lin@broadcom•com>
> Cc: Hante Meuleman <hante.meuleman@broadcom•com>
> Cc: Chi-Hsien Lin <chi-hsien.lin@cypress•com>
> Cc: Wright Feng <wright.feng@cypress•com>
> Cc: Kalle Valo <kvalo@codeaurora•org>
> Cc: "David S. Miller" <davem@davemloft•net>
> Cc: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom•com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> Cc: "Rafał Miłecki" <rafal@milecki•pl>
> Cc: linux-wireless@vger•kernel.org
> Cc: brcm80211-dev-list.pdl@broadcom•com
> Cc: brcm80211-dev-list@cypress•com
> Cc: netdev@vger•kernel.org
> Cc: linux-kernel@vger•kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom•com>
Patch applied to wireless-drivers-next.git, thanks.
ea1b3bc6d5ad brcmfmac: no need to check return value of debugfs_create functions
--
https://patchwork.kernel.org/patch/11516617/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-05-04 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 10:15 [PATCH] brcmfmac: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2020-04-29 10:24 ` Arend Van Spriel
2020-05-04 9:50 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504095042.4289CC432C2@smtp.codeaurora.org \
--to=kvalo@codeaurora$(echo .)org \
--cc=arend.vanspriel@broadcom$(echo .)com \
--cc=brcm80211-dev-list.pdl@broadcom$(echo .)com \
--cc=brcm80211-dev-list@cypress$(echo .)com \
--cc=chi-hsien.lin@cypress$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=franky.lin@broadcom$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hante.meuleman@broadcom$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pieter-paul.giesberts@broadcom$(echo .)com \
--cc=rafal@milecki$(echo .)pl \
--cc=wright.feng@cypress$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox