Subject: Re: [PATCH net-next] net: sfp: add some quirks for FreeTel direct attach modules

From: Russell King - ARM Linux admin <[email-masked]>
Date: Fri, 8 May 2020 16:02:27 +0100

On Fri, May 08, 2020 at 05:30:06PM +0300, Denis Kirjanov wrote:
> On Thursday, May 7, 2020, Marek Behún <[email-masked]> wrote:
> 
> > FreeTel P.C30.2 and P.C30.3 may fail to report anything useful from
> > their EEPROM. They report correct nominal bitrate of 10300 MBd, but do
> > not report sfp_ct_passive nor sfp_ct_active in their ERPROM.
> >
> > These modules can also operate at 1000baseX and 2500baseX.
> >
> > Signed-off-by: Marek Behún <[email-masked]>
> > Cc: Russell King <[email-masked]>
> > ---
> >  drivers/net/phy/sfp-bus.c | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c
> > index 6900c68260e0..f021709bedcc 100644
> > --- a/drivers/net/phy/sfp-bus.c
> > +++ b/drivers/net/phy/sfp-bus.c
> > @@ -44,6 +44,14 @@ static void sfp_quirk_2500basex(const struct
> > sfp_eeprom_id *id,
> >         phylink_set(modes, 2500baseX_Full);
> >  }
> >
> > +static void sfp_quirk_direct_attach_10g(const struct sfp_eeprom_id *id,
> > +                                       unsigned long *modes)
> > +{
> > +       phylink_set(modes, 10000baseCR_Full);
> > +       phylink_set(modes, 2500baseX_Full);
> > +       phylink_set(modes, 1000baseX_Full);
> > +}
> > +
> >  static const struct sfp_quirk sfp_quirks[] = {
> >         {
> >                 // Alcatel Lucent G-010S-P can operate at 2500base-X, but
> > @@ -63,6 +71,18 @@ static const struct sfp_quirk sfp_quirks[] = {
> >                 .vendor = "HUAWEI",
> >                 .part = "MA5671A",
> >                 .modes = sfp_quirk_2500basex,
> > +       }, {
> > +               // FreeTel P.C30.2 is a SFP+ direct attach that can
> > operate at
> > +               // at 1000baseX, 2500baseX and 10000baseCR, but may report
> > none
> > +               // of these in their EEPROM
> 
> 
>  Hi Marek,
> 
> The comment style above is not what Linux kernel uses

The comment style is per file - keeping consistency within a file is
far more important than rigid conformance to some coding style. That
is, unless someone is prepared to convert said file.  The commenting
style for these entries is to use "//" style.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up