From: Luis Chamberlain <mcgrof@kernel•org>
To: jeyu@kernel•org
Cc: akpm@linux-foundation•org, arnd@arndb•de, rostedt@goodmis•org,
mingo@redhat•com, aquini@redhat•com, cai@lca•pw,
dyoung@redhat•com, bhe@redhat•com, peterz@infradead•org,
tglx@linutronix•de, gpiccoli@canonical•com, pmladek@suse•com,
tiwai@suse•de, schlad@suse•de, andriy.shevchenko@linux•intel.com,
keescook@chromium•org, daniel.vetter@ffwll•ch, will@kernel•org,
mchehab+samsung@kernel•org, kvalo@codeaurora•org,
davem@davemloft•net, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
Luis Chamberlain <mcgrof@kernel•org>,
"Michael S. Tsirkin" <mst@redhat•com>,
Shannon Nelson <snelson@pensando•io>,
Jakub Kicinski <kuba@kernel•org>,
Heiner Kallweit <hkallweit1@gmail•com>
Subject: [PATCH 02/15] ethernet/839: use new module_firmware_crashed()
Date: Sat, 9 May 2020 04:35:39 +0000 [thread overview]
Message-ID: <20200509043552.8745-3-mcgrof@kernel.org> (raw)
In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org>
This makes use of the new module_firmware_crashed() to help
annotate when firmware for device drivers crash. When firmware
crashes devices can sometimes become unresponsive, and recovery
sometimes requires a driver unload / reload and in the worst cases
a reboot.
Using a taint flag allows us to annotate when this happens clearly.
Cc: "Michael S. Tsirkin" <mst@redhat•com>
Cc: Shannon Nelson <snelson@pensando•io>
Cc: Jakub Kicinski <kuba@kernel•org>
Cc: Heiner Kallweit <hkallweit1@gmail•com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel•org>
---
drivers/net/ethernet/8390/axnet_cs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/8390/axnet_cs.c b/drivers/net/ethernet/8390/axnet_cs.c
index aeae7966a082..8ad0200db8e9 100644
--- a/drivers/net/ethernet/8390/axnet_cs.c
+++ b/drivers/net/ethernet/8390/axnet_cs.c
@@ -1358,9 +1358,11 @@ static void ei_receive(struct net_device *dev)
*/
if ((netif_msg_rx_err(ei_local)) &&
this_frame != ei_local->current_page &&
- (this_frame != 0x0 || rxing_page != 0xFF))
+ (this_frame != 0x0 || rxing_page != 0xFF)) {
+ module_firmware_crashed();
netdev_err(dev, "mismatched read page pointers %2x vs %2x\n",
this_frame, ei_local->current_page);
+ }
if (this_frame == rxing_page) /* Read all the frames? */
break; /* Done for now */
--
2.25.1
next prev parent reply other threads:[~2020-05-09 4:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 4:35 [PATCH 00/15] net: taint when the device driver firmware crashes Luis Chamberlain
2020-05-09 4:35 ` [PATCH 01/15] taint: add module firmware crash taint support Luis Chamberlain
2020-05-09 15:18 ` Rafael Aquini
2020-05-09 16:46 ` Luis Chamberlain
2020-05-10 2:19 ` Randy Dunlap
2020-05-09 4:35 ` Luis Chamberlain [this message]
2020-05-09 4:35 ` [PATCH 03/15] bnx2x: use new module_firmware_crashed() Luis Chamberlain
2020-05-09 4:35 ` [PATCH 04/15] bnxt: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 05/15] bna: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 06/15] liquidio: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 07/15] cxgb4: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 08/15] ehea: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 09/15] qed: " Luis Chamberlain
2020-05-09 6:32 ` [EXT] " Igor Russkikh
2020-05-09 16:42 ` Luis Chamberlain
2020-05-12 16:23 ` Igor Russkikh
2020-05-12 17:34 ` Luis Chamberlain
2020-05-14 14:53 ` Igor Russkikh
2020-05-15 20:32 ` Luis Chamberlain
2020-05-15 20:37 ` Igor Russkikh
2020-05-09 4:35 ` [PATCH 10/15] soc: qcom: ipa: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 11/15] wimax/i2400m: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 12/15] ath10k: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 13/15] ath6kl: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 14/15] brcm80211: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 15/15] mwl8k: " Luis Chamberlain
2020-05-09 18:35 ` [PATCH 00/15] net: taint when the device driver firmware crashes Jakub Kicinski
2020-05-11 14:11 ` Luis Chamberlain
2020-05-10 1:01 ` Shannon Nelson
2020-05-10 1:58 ` Andrew Lunn
2020-05-10 2:15 ` Shannon Nelson
2020-05-11 14:13 ` Luis Chamberlain
2020-05-11 19:21 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509043552.8745-3-mcgrof@kernel.org \
--to=mcgrof@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=aquini@redhat$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bhe@redhat$(echo .)com \
--cc=cai@lca$(echo .)pw \
--cc=daniel.vetter@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dyoung@redhat$(echo .)com \
--cc=gpiccoli@canonical$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jeyu@kernel$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mchehab+samsung@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=schlad@suse$(echo .)de \
--cc=snelson@pensando$(echo .)io \
--cc=tglx@linutronix$(echo .)de \
--cc=tiwai@suse$(echo .)de \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox