From: Michael Grzeschik <mgr@pengutronix•de>
To: Andrew Lunn <andrew@lunn•ch>
Cc: netdev@vger•kernel.org, f.fainelli@gmail•com,
davem@davemloft•net, kernel@pengutronix•de
Subject: Re: [PATCH v3 3/5] net: tag: ksz: Add KSZ8863 tag code
Date: Mon, 11 May 2020 17:38:38 +0200 [thread overview]
Message-ID: <20200511153838.GL20451@pengutronix.de> (raw)
In-Reply-To: <20200509164105.GA362499@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]
On Sat, May 09, 2020 at 06:41:05PM +0200, Andrew Lunn wrote:
>> +/* For ingress (Host -> KSZ8863), 1 byte is added before FCS.
>> + * ---------------------------------------------------------------------------
>> + * DA(6bytes)|SA(6bytes)|....|Data(nbytes)|tag0(1byte)|tag1(1byte)|FCS(4bytes)
>> + * ---------------------------------------------------------------------------
>> + * tag0[1,0] : represents port
>> + * (e.g. 0b00=addr-lookup 0b01=port1, 0b10=port2, 0b11=port1+port2)
>> + * tag0[3,2] : bits two and three represent prioritization
>> + * (e.g. 0b00xx=prio0, 0b01xx=prio1, 0b10xx=prio2, 0b11xx=prio3)
>> + *
>> + * For egress (KSZ8873 -> Host), 1 byte is added before FCS.
>> + * ---------------------------------------------------------------------------
>> + * DA(6bytes)|SA(6bytes)|....|Data(nbytes)|tag0(1byte)|FCS(4bytes)
>> + * ---------------------------------------------------------------------------
>> + * tag0[0] : zero-based value represents port
>> + * (eg, 0b0=port1, 0b1=port2)
>> + */
>> +
>> +static struct sk_buff *ksz8863_xmit(struct sk_buff *skb,
>> + struct net_device *dev)
>> +{
>> + struct dsa_port *dp = dsa_slave_to_port(dev);
>> + struct sk_buff *nskb;
>> + __be16 *tag;
>
>The comment says 1 byte is added. But tag is a u16?
You are absolutely right. I fixed it for v4.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-11 15:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 15:43 [PATCH v3 0/5] microchip: add support for ksz88x3 driver family Michael Grzeschik
2020-05-08 15:43 ` [PATCH v3 1/5] net: phy: Add support for microchip SMI0 MDIO bus Michael Grzeschik
2020-05-09 17:28 ` Florian Fainelli
2020-05-09 19:25 ` Andrew Lunn
2020-05-11 15:40 ` Michael Grzeschik
2020-05-08 15:43 ` [PATCH v3 2/5] dt-bindings: net: mdio-gpio: add compatible for microchip,mdio-smi0 Michael Grzeschik
2020-05-09 16:57 ` Andrew Lunn
2020-05-09 17:16 ` Florian Fainelli
2020-05-19 18:21 ` Rob Herring
2020-05-08 15:43 ` [PATCH v3 3/5] net: tag: ksz: Add KSZ8863 tag code Michael Grzeschik
2020-05-09 16:41 ` Andrew Lunn
2020-05-11 15:38 ` Michael Grzeschik [this message]
2020-05-08 15:43 ` [PATCH v3 4/5] ksz: Add Microchip KSZ8863 SMI/SPI based driver support Michael Grzeschik
2020-05-09 16:56 ` Andrew Lunn
2020-05-11 15:39 ` Michael Grzeschik
2020-05-08 15:43 ` [PATCH v3 5/5] dt-bindings: net: dsa: document additional Microchip KSZ8863/8873 switch Michael Grzeschik
2020-05-09 16:57 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511153838.GL20451@pengutronix.de \
--to=mgr@pengutronix$(echo .)de \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox