Subject: Re: [PATCH][next] rndis_wlan: Remove logically dead code

From: Kalle Valo <[email-masked]>
Date: Tue, 12 May 2020 08:53:36 +0000 (UTC)

"Gustavo A. R. Silva" <[email-masked]> wrote:

> caps_buf is always of size sizeof(*caps) because
> sizeof(caps->auth_encr_pair) * 16 is always zero. Notice
> that when using zero-length arrays, sizeof evaluates to zero[1].
> 
> So, the code introduced by 
> commit 0308383f9591 ("rndis_wlan: get max_num_pmkids from device")
> is logically dead, hence is never executed and can be removed. As a
> consequence, the rest of the related code can be refactored a bit.
> 
> Notice that this code has been out there since March 2010.
> 
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> Signed-off-by: Gustavo A. R. Silva <[email-masked]>

Patch applied to wireless-drivers-next.git, thanks.

485c64be7152 rndis_wlan: Remove logically dead code

-- 
https://patchwork.kernel.org/patch/11530089/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches