From: Jiri Olsa <jolsa@redhat•com>
To: Andrii Nakryiko <andrii.nakryiko@gmail•com>
Cc: Jiri Olsa <jolsa@kernel•org>, Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Wenbo Zhang <ethercflow@gmail•com>,
Networking <netdev@vger•kernel.org>, bpf <bpf@vger•kernel.org>,
Yonghong Song <yhs@fb•com>, Martin KaFai Lau <kafai@fb•com>,
David Miller <davem@redhat•com>,
John Fastabend <john.fastabend@gmail•com>,
Jesper Dangaard Brouer <hawk@kernel•org>,
KP Singh <kpsingh@chromium•org>, Andrii Nakryiko <andriin@fb•com>,
Brendan Gregg <bgregg@netflix•com>,
Florent Revest <revest@chromium•org>,
Al Viro <viro@zeniv•linux.org.uk>
Subject: Re: [PATCH 8/9] selftests/bpf: Add test for d_path helper
Date: Fri, 15 May 2020 16:57:25 +0200 [thread overview]
Message-ID: <20200515145725.GA3565839@krava> (raw)
In-Reply-To: <CAEf4Bzbn_m8HUmvkBwK9t3-CkO+gz4SvAvMsO7aUQ49v3skh=w@mail.gmail.com>
On Thu, May 14, 2020 at 03:48:20PM -0700, Andrii Nakryiko wrote:
> On Wed, May 6, 2020 at 6:32 AM Jiri Olsa <jolsa@kernel•org> wrote:
> >
> > Adding test for d_path helper which is pretty much
> > copied from Wenbo Zhang's test for bpf_get_fd_path,
> > which never made it in.
> >
> > I've failed so far to compile the test with <linux/fs.h>
> > kernel header, so for now adding 'struct file' with f_path
> > member that has same offset as kernel's file object.
> >
>
> Switch to using vmlinux.h? It would also be nice to use skeletons
> instead of bpf_object__xxx API.
I just spot it this week when checking for something else.. yep, nice ;-)
thanks,
jirka
>
> > Original-patch-by: Wenbo Zhang <ethercflow@gmail•com>
> > Signed-off-by: Jiri Olsa <jolsa@kernel•org>
> > ---
> > .../testing/selftests/bpf/prog_tests/d_path.c | 196 ++++++++++++++++++
> > .../testing/selftests/bpf/progs/test_d_path.c | 71 +++++++
> > 2 files changed, 267 insertions(+)
> > create mode 100644 tools/testing/selftests/bpf/prog_tests/d_path.c
> > create mode 100644 tools/testing/selftests/bpf/progs/test_d_path.c
> >
>
> [...]
>
next prev parent reply other threads:[~2020-05-15 14:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 13:29 [RFCv2 0/9] bpf: Add d_path helper Jiri Olsa
2020-05-06 13:29 ` [PATCH 1/9] " Jiri Olsa
2020-05-14 22:06 ` Andrii Nakryiko
2020-05-15 14:59 ` Jiri Olsa
2020-05-06 13:29 ` [PATCH 2/9] bpf: Add d_path whitelist Jiri Olsa
2020-05-06 13:29 ` [PATCH 3/9] bpf: Add bpfwl tool to construct bpf whitelists Jiri Olsa
2020-05-14 22:20 ` Andrii Nakryiko
2020-05-15 14:58 ` Jiri Olsa
2020-05-06 13:29 ` [PATCH 4/9] bpf: Allow nested BTF object to be refferenced by BTF object + offset Jiri Olsa
2020-05-14 22:32 ` Andrii Nakryiko
2020-05-06 13:29 ` [PATCH 5/9] bpf: Add support to check on BTF id whitelist for d_path helper Jiri Olsa
2020-05-06 13:29 ` [PATCH 6/9] bpf: Compile bpfwl tool at kernel compilation start Jiri Olsa
2020-05-14 22:38 ` Andrii Nakryiko
2020-05-15 14:57 ` Jiri Olsa
2020-05-06 13:29 ` [PATCH 7/9] bpf: Compile the BTF id whitelist data in vmlinux Jiri Olsa
2020-05-13 18:29 ` Alexei Starovoitov
2020-05-14 8:05 ` Jiri Olsa
2020-05-14 22:46 ` Andrii Nakryiko
2020-05-15 14:57 ` Jiri Olsa
2020-05-28 17:23 ` Jiri Olsa
2020-05-29 20:48 ` Andrii Nakryiko
2020-05-31 15:10 ` Jiri Olsa
2020-06-01 19:06 ` Andrii Nakryiko
2020-06-02 8:16 ` Jiri Olsa
2020-05-06 13:29 ` [PATCH 8/9] selftests/bpf: Add test for d_path helper Jiri Olsa
2020-05-14 22:48 ` Andrii Nakryiko
2020-05-15 14:57 ` Jiri Olsa [this message]
2020-05-06 13:29 ` [PATCH 9/9] selftests/bpf: Add verifier " Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515145725.GA3565839@krava \
--to=jolsa@redhat$(echo .)com \
--cc=andrii.nakryiko@gmail$(echo .)com \
--cc=andriin@fb$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bgregg@netflix$(echo .)com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@redhat$(echo .)com \
--cc=ethercflow@gmail$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kafai@fb$(echo .)com \
--cc=kpsingh@chromium$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=revest@chromium$(echo .)org \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox