From: Luis Chamberlain <mcgrof@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: jeyu@kernel•org, davem@davemloft•net, michael.chan@broadcom•com,
dchickles@marvell•com, sburla@marvell•com, fmanlunas@marvell•com,
aelior@marvell•com, GR-everest-linux-l2@marvell•com,
kvalo@codeaurora•org, johannes@sipsolutions•net,
akpm@linux-foundation•org, arnd@arndb•de, rostedt@goodmis•org,
mingo@redhat•com, aquini@redhat•com, cai@lca•pw,
dyoung@redhat•com, bhe@redhat•com, peterz@infradead•org,
tglx@linutronix•de, gpiccoli@canonical•com, pmladek@suse•com,
tiwai@suse•de, schlad@suse•de, andriy.shevchenko@linux•intel.com,
derosier@gmail•com, keescook@chromium•org,
daniel.vetter@ffwll•ch, will@kernel•org,
mchehab+samsung@kernel•org, vkoul@kernel•org,
mchehab+huawei@kernel•org, robh@kernel•org, mhiramat@kernel•org,
sfr@canb•auug.org.au, linux@dominikbrodowski•net,
glider@google•com, paulmck@kernel•org, elver@google•com,
bauerman@linux•ibm.com, yamada.masahiro@socionext•com,
samitolvanen@google•com, yzaikin@google•com, dvyukov@google•com,
rdunlap@infradead•org, corbet@lwn•net, dianders@chromium•org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-doc@vger•kernel.org
Subject: Re: [PATCH v3 0/8] kernel: taint when the driver firmware crashes
Date: Tue, 26 May 2020 23:07:48 +0000 [thread overview]
Message-ID: <20200526230748.GS11244@42.do-not-panic.com> (raw)
In-Reply-To: <20200526154606.6a2be01f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On Tue, May 26, 2020 at 03:46:06PM -0700, Jakub Kicinski wrote:
> On Tue, 26 May 2020 14:58:07 +0000 Luis Chamberlain wrote:
> > To those new on CC -- this is intended to be a simple generic interface
> > to the kernel to annotate when the firwmare has crashed leaving the
> > driver or system in a questionable state, in the worst case requiring
> > full system reboot. This series is first addressing only a few
> > networking patches, however, I already have an idea of where such
> > firmware crashes happen across the tree. The goal with this series then
> > is to first introduce the simple framework, and only if that moves
> > forward will I continue to chug on with the rest of the drivers /
> > subsystems.
> >
> > This is *not* a networking specific problem only.
> >
> > This v3 augments the last series by introducing the uevent for panic
> > events, one of them is during tainting. The uvent mechanism is
> > independent from any of this firmware taint mechanism. I've also
> > addressed Jessica Yu's feedback. Given I've extended the patches a bit
> > with other minor cleanup which checkpatch.pl complains over, and since
> > this infrastructure is still being discussed, I've trimmed the patch
> > series size to only cover drivers for which I've received an Acked-by
> > from the respective driver maintainer, or where we have bug reports to
> > support such dire situations on the driver such as ath10k.
> >
> > During the last v2 it was discussed that we should instead use devlink
> > for this work, however the initial RFC patches produced by Jakub
> > Kicinski [0] shows how devlink is networking specific, and the intent
> > behind this series is to produce simple helpers which can be used by *any*
> > device driver, for any subsystem, not just networking. Subsystem
> > specific infrastructure to help address firwmare crashes may still make
> > sense, however that does not mean we *don't* need something even more
> > generic regardless of the subsystem the issue happens on. Since uevents
> > for taints are exposed, we now expose these through uapi as well, and
> > that was something which eventually had to happen given that the current
> > scheme of relying on sensible character representations for each taint
> > will not scale beyond the alphabet.
>
> Nacked-by: Jakub Kicinski <kuba@kernel•org>
Care to elaborate?
Luis
next prev parent reply other threads:[~2020-05-26 23:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 14:58 [PATCH v3 0/8] kernel: taint when the driver firmware crashes Luis Chamberlain
2020-05-26 14:58 ` [PATCH v3 1/8] kernel.h: move taint and system state flags to uapi Luis Chamberlain
2020-05-26 14:58 ` [PATCH v3 2/8] panic: add uevent support Luis Chamberlain
2020-05-26 14:58 ` [PATCH v3 3/8] taint: add firmware crash taint support Luis Chamberlain
2020-05-26 14:58 ` [PATCH v3 4/8] panic: make taint data type clearer Luis Chamberlain
2020-05-26 14:58 ` [PATCH v3 5/8] ath10k: use new taint_firmware_crashed() Luis Chamberlain
2020-06-02 21:01 ` Brian Norris
2020-05-26 14:58 ` [PATCH v3 6/8] bnxt_en: " Luis Chamberlain
2020-05-26 18:09 ` Michael Chan
2020-05-26 14:58 ` [PATCH v3 7/8] liquidio: " Luis Chamberlain
2020-05-26 14:58 ` [PATCH v3 8/8] qed: " Luis Chamberlain
2020-05-26 22:46 ` [PATCH v3 0/8] kernel: taint when the driver firmware crashes Jakub Kicinski
2020-05-26 23:07 ` Luis Chamberlain [this message]
2020-05-26 23:30 ` Jakub Kicinski
2020-05-27 3:19 ` Luis Chamberlain
2020-05-27 21:36 ` Jakub Kicinski
2020-05-28 14:27 ` Luis Chamberlain
2020-05-28 15:04 ` Ben Greear
2020-05-28 16:33 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526230748.GS11244@42.do-not-panic.com \
--to=mcgrof@kernel$(echo .)org \
--cc=GR-everest-linux-l2@marvell$(echo .)com \
--cc=aelior@marvell$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=aquini@redhat$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bauerman@linux$(echo .)ibm.com \
--cc=bhe@redhat$(echo .)com \
--cc=cai@lca$(echo .)pw \
--cc=corbet@lwn$(echo .)net \
--cc=daniel.vetter@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dchickles@marvell$(echo .)com \
--cc=derosier@gmail$(echo .)com \
--cc=dianders@chromium$(echo .)org \
--cc=dvyukov@google$(echo .)com \
--cc=dyoung@redhat$(echo .)com \
--cc=elver@google$(echo .)com \
--cc=fmanlunas@marvell$(echo .)com \
--cc=glider@google$(echo .)com \
--cc=gpiccoli@canonical$(echo .)com \
--cc=jeyu@kernel$(echo .)org \
--cc=johannes@sipsolutions$(echo .)net \
--cc=keescook@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@dominikbrodowski$(echo .)net \
--cc=mchehab+huawei@kernel$(echo .)org \
--cc=mchehab+samsung@kernel$(echo .)org \
--cc=mhiramat@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulmck@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=samitolvanen@google$(echo .)com \
--cc=sburla@marvell$(echo .)com \
--cc=schlad@suse$(echo .)de \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
--cc=tiwai@suse$(echo .)de \
--cc=vkoul@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=yamada.masahiro@socionext$(echo .)com \
--cc=yzaikin@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox