Subject: Re: [PATCH] net: atm: Replace kmalloc with kzalloc in the error message

From: Andy Shevchenko <[email-masked]>
Date: Fri, 29 May 2020 12:22:55 +0300

On Fri, May 29, 2020 at 09:01:42AM +0800, Yi Wang wrote:
> From: Liao Pingfang <[email-masked]>
> 
> Use kzalloc instead of kmalloc in the error message according to
> the previous kzalloc() call.

Looking into the context (atomic!) and error message itself I would rather drop
message completely.

> Signed-off-by: Liao Pingfang <[email-masked]>
> ---
>  net/atm/lec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/atm/lec.c b/net/atm/lec.c
> index ca37f5a..33033d7 100644
> --- a/net/atm/lec.c
> +++ b/net/atm/lec.c
> @@ -1537,7 +1537,7 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,
>  
>  	to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);
>  	if (!to_return) {
> -		pr_info("LEC: Arp entry kmalloc failed\n");
> +		pr_info("LEC: Arp entry kzalloc failed\n");
>  		return NULL;
>  	}
>  	ether_addr_copy(to_return->mac_addr, mac_addr);
> -- 
> 2.9.5
> 

-- 
With Best Regards,
Andy Shevchenko