From: Kees Cook <keescook@chromium•org>
To: David Laight <David.Laight@ACULAB•COM>
Cc: "linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Sargun Dhillon <sargun@sargun•me>,
Christian Brauner <christian@brauner•io>,
"David S. Miller" <davem@davemloft•net>,
Christoph Hellwig <hch@lst•de>, Tycho Andersen <tycho@tycho•ws>,
Jakub Kicinski <kuba@kernel•org>,
Alexander Viro <viro@zeniv•linux.org.uk>,
Aleksa Sarai <cyphar@cyphar•com>,
Matt Denton <mpdenton@google•com>, Jann Horn <jannh@google•com>,
Chris Palmer <palmer@google•com>,
Robert Sesek <rsesek@google•com>,
Giuseppe Scrivano <gscrivan@redhat•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Andy Lutomirski <luto@amacapital•net>,
Will Drewry <wad@chromium•org>, Shuah Khan <shuah@kernel•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"containers@lists•linux-foundation.org"
<containers@lists•linux-foundation.org>,
"linux-api@vger•kernel.org" <linux-api@vger•kernel.org>,
"linux-fsdevel@vger•kernel.org" <linux-fsdevel@vger•kernel.org>,
"linux-kselftest@vger•kernel.org"
<linux-kselftest@vger•kernel.org>
Subject: Re: [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received()
Date: Wed, 17 Jun 2020 11:40:20 -0700 [thread overview]
Message-ID: <202006171139.98B1735@keescook> (raw)
In-Reply-To: <b58ef9a368214b69a86c7a78b67f84d5@AcuMS.aculab.com>
On Wed, Jun 17, 2020 at 03:25:41PM +0000, David Laight wrote:
> From: Kees Cook
> > Sent: 16 June 2020 04:25
>
> > In preparation for users of the "install a received file" logic outside
> > of net/ (pidfd and seccomp), relocate and rename __scm_install_fd() from
> > net/core/scm.c to __fd_install_received() in fs/file.c, and provide a
> > wrapper named fd_install_received_user(), as future patches will change
> > the interface to __fd_install_received().
>
> Any reason for the leading __ ??
Mainly because of the code pattern of only using the inline helpers to
call it.
--
Kees Cook
next prev parent reply other threads:[~2020-06-17 18:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 3:25 [PATCH v4 00/11] Add seccomp notifier ioctl that enables adding fds Kees Cook
2020-06-16 3:25 ` [PATCH v4 01/11] net/scm: Regularize compat handling of scm_detach_fds() Kees Cook
2020-06-16 3:25 ` [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received() Kees Cook
2020-06-16 5:29 ` Sargun Dhillon
2020-06-16 5:48 ` Kees Cook
2020-06-17 15:25 ` David Laight
2020-06-17 18:40 ` Kees Cook [this message]
2020-06-18 8:56 ` Christian Brauner
2020-06-18 20:05 ` Kees Cook
2020-06-16 3:25 ` [PATCH v4 03/11] fs: Add fd_install_received() wrapper for __fd_install_received() Kees Cook
2020-06-17 15:35 ` David Laight
2020-06-17 19:58 ` Kees Cook
2020-06-18 8:19 ` David Laight
2020-06-16 3:25 ` [PATCH v4 04/11] pidfd: Replace open-coded partial fd_install_received() Kees Cook
2020-06-16 3:25 ` [PATCH v4 05/11] fs: Expand __fd_install_received() to accept fd Kees Cook
2020-06-16 3:25 ` [PATCH v4 06/11] seccomp: Introduce addfd ioctl to seccomp user notifier Kees Cook
2020-06-16 3:25 ` [PATCH v4 07/11] selftests/seccomp: Test SECCOMP_IOCTL_NOTIF_ADDFD Kees Cook
2020-06-16 3:25 ` [PATCH v4 08/11] selftests/seccomp: Make kcmp() less required Kees Cook
2020-06-16 14:57 ` Tycho Andersen
2020-06-16 16:03 ` Kees Cook
2020-06-16 3:25 ` [PATCH v4 09/11] selftests/seccomp: Rename user_trap_syscall() to user_notif_syscall() Kees Cook
2020-06-16 14:56 ` Tycho Andersen
2020-06-16 3:25 ` [PATCH v4 10/11] seccomp: Switch addfd to Extensible Argument ioctl Kees Cook
2020-06-16 14:55 ` Tycho Andersen
2020-06-16 16:05 ` Kees Cook
2020-06-16 16:18 ` Tycho Andersen
2020-06-16 3:25 ` [PATCH v4 11/11] seccomp: Fix ioctl number for SECCOMP_IOCTL_NOTIF_ID_VALID Kees Cook
2020-06-18 22:16 ` [PATCH v4 00/11] Add seccomp notifier ioctl that enables adding fds Sargun Dhillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006171139.98B1735@keescook \
--to=keescook@chromium$(echo .)org \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=christian@brauner$(echo .)io \
--cc=containers@lists$(echo .)linux-foundation.org \
--cc=cyphar@cyphar$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gscrivan@redhat$(echo .)com \
--cc=hch@lst$(echo .)de \
--cc=jannh@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=luto@amacapital$(echo .)net \
--cc=mpdenton@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=palmer@google$(echo .)com \
--cc=rsesek@google$(echo .)com \
--cc=sargun@sargun$(echo .)me \
--cc=shuah@kernel$(echo .)org \
--cc=tycho@tycho$(echo .)ws \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=wad@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox