Subject: Re: [net-next PATCH 2/5 v2] net: dsa: rtl8366rb: Support the CPU DSA tag

From: Andrew Lunn <[email-masked]>
Date: Thu, 18 Jun 2020 03:27:55 +0200

On Wed, Jun 17, 2020 at 10:31:29AM +0200, Linus Walleij wrote:
> This activates the support to use the CPU tag to properly
> direct ingress traffic to the right port.
> 
> Bit 15 in register RTL8368RB_CPU_CTRL_REG can be set to
> 1 to disable the insertion of the CPU tag which is what
> the code currently does. The bit 15 define calls this
> setting RTL8368RB_CPU_INSTAG which is confusing since the
> iverse meaning is implied: programmers may think that

inverse

> setting this bit to 1 will *enable* inserting the tag
> rather than disablinbg it, so rename this setting in

disabling

> bit 15 to RTL8368RB_CPU_NO_TAG which is more to the
> point.
> 
> After this e.g. ping works out-of-the-box with the
> RTL8366RB.
> 
> Cc: DENG Qingfang <[email-masked]>
> Cc: Mauri Sandberg <[email-masked]>
> Signed-off-by: Linus Walleij <[email-masked]>

Reviewed-by: Andrew Lunn <[email-masked]>

    Andrew