From: Stephen Hemminger <stephen@networkplumber•org>
To: Anton Danilov <littlesmilingcloud@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH v2] tc: qdisc: filter qdisc's by parent/handle specification
Date: Thu, 18 Jun 2020 15:17:02 -0700 [thread overview]
Message-ID: <20200618151702.24c33261@hermes.lan> (raw)
In-Reply-To: <20200616063902.15605-1-littlesmilingcloud@gmail.com>
On Tue, 16 Jun 2020 09:39:02 +0300
Anton Danilov <littlesmilingcloud@gmail•com> wrote:
> + fprintf(stderr,
> + "only one of parent/handle/root/ingress can be specified\n");
> + arg_error = true;
> + break;
The concept is good, but it could be simplified.
You are repeating same error message several places and it is not
necessary to continue parsing after one bad argument.
See what invarg() does.
next prev parent reply other threads:[~2020-06-18 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 6:39 [PATCH v2] tc: qdisc: filter qdisc's by parent/handle specification Anton Danilov
2020-06-18 22:17 ` Stephen Hemminger [this message]
2020-06-24 17:03 ` Anton Danilov
2020-07-03 15:39 ` [PATCH iproute2 v3] tc: improve the qdisc show command Anton Danilov
2020-07-06 18:01 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618151702.24c33261@hermes.lan \
--to=stephen@networkplumber$(echo .)org \
--cc=littlesmilingcloud@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox