From: Stephen Hemminger <stephen@networkplumber•org>
To: Michal Kubecek <mkubecek@suse•cz>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH iproute2 0/5] Eliminate the term slave in iproute2
Date: Wed, 24 Jun 2020 08:21:37 -0700 [thread overview]
Message-ID: <20200624082137.68dc44b0@hermes.lan> (raw)
In-Reply-To: <20200624095142.zete44mbrtieepju@lion.mk-sys.cz>
On Wed, 24 Jun 2020 11:51:42 +0200
Michal Kubecek <mkubecek@suse•cz> wrote:
> On Tue, Jun 23, 2020 at 04:53:02PM -0700, Stephen Hemminger wrote:
> > These patches remove the term slave from the iproute2 visible
> > command line, documentation, and variable naming.
> >
> > This needs doing despite the fact it will cause cosmetic
> > changes to visible outputs.
>
> AFAICS, your patches don't only change output of the command, they also
> change command line parsing so that they break backward compatibility
> and break existing scripts and tools. This is a very bad idea.
>
> If you really want to go through this exercise - and I don't agree with
> the "needs doing" claim - you definitely should preserve existing
> keywords as aliases.
>
> Michal
Sure the old keywords could be silent aliases for new ones.
prev parent reply other threads:[~2020-06-24 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 23:53 [PATCH iproute2 0/5] Eliminate the term slave in iproute2 Stephen Hemminger
2020-06-23 23:53 ` [PATCH iproute2 1/5] bpf: replace slave with sub Stephen Hemminger
2020-06-23 23:53 ` [PATCH iproute2 2/5] bridge: remove slave from comments and message Stephen Hemminger
2020-06-23 23:53 ` [PATCH iproute2 3/5] testsuite: replace Enslave with Insert Stephen Hemminger
2020-06-23 23:53 ` [PATCH iproute2 4/5] ip: replace slave_kind Stephen Hemminger
2020-06-23 23:53 ` [PATCH iproute2 5/5] ip: rename slave to subport Stephen Hemminger
2020-06-24 0:12 ` [PATCH iproute2 0/5] Eliminate the term slave in iproute2 Jakub Kicinski
2020-06-24 9:51 ` Michal Kubecek
2020-06-24 15:21 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624082137.68dc44b0@hermes.lan \
--to=stephen@networkplumber$(echo .)org \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox