Subject: Re: [PATCH v4 bpf-next 6/9] bpf: cpumap: implement XDP_REDIRECT for eBPF programs attached to map entries

From: Lorenzo Bianconi <[email-masked]>
Date: Fri, 26 Jun 2020 09:59:06 +0200

> On 6/24/20 5:33 PM, Lorenzo Bianconi wrote:

[...]

> > +	if (stats->redirect)
> > +		xdp_do_flush_map();
> > +
> > +	rcu_read_unlock_bh(); /* resched point, may call do_softirq() */
> >   	xdp_clear_return_frame_no_direct();
> 
> Hm, this looks incorrect. Why do you call the xdp_clear_return_frame_no_direct() /after/
> the possibility where there is a rescheduling point for softirq?

Hi Daniel,

yes, right. Thx for spotting this, I will fix in v5.

Regards,
Lorenzo

> >   	return nframes;