From: Andrew Lunn <andrew@lunn•ch>
To: Russell King <rmk+kernel@armlinux•org.uk>
Cc: Richard Cochran <richardcochran@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Heiner Kallweit <hkallweit1@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
netdev@vger•kernel.org
Subject: Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support
Date: Wed, 15 Jul 2020 20:38:43 +0200 [thread overview]
Message-ID: <20200715183843.GA1256692@lunn.ch> (raw)
In-Reply-To: <E1jvNlE-0001Y0-47@rmk-PC.armlinux.org.uk>
> Getting the Kconfig for this correct has been a struggle - particularly
> the combination where PTP support is modular. It's rather odd to have
> the Marvell PTP support asked before the Marvell PHY support. I
> couldn't work out any other reasonable way to ensure that we always
> have a valid configuration, without leading to stupidities such as
> having the PTP and Marvell PTP support modular, but non-functional
> because Marvell PHY is built-in.
Hi Russell
How much object code is this adding? All the other PHYs which support
PTP just make it part of the PHY driver, not a standalone module. That
i guess simplifies the conditions.
Looking at DSDT, it lists
case MAD_88E1340S:
case MAD_88E1340:
case MAD_88E1340M:
case MAD_SWG65G :
case MAD_88E151x:
as being MAD_PHY_PTP_TAI_CAPABLE;
and
case MAD_88E1548
case MAD_88E1680:
case MAD_88E1680M:
as MAD_PHY_1STEP_PTP_CAPABLE;
So maybe we can wire this up to a few more PHYs to 'lower' the
overhead a bit?
> It seems that the Marvell PHY PTP is very similar to that found in
> their DSA chips, which suggests maybe we should share the code, but
> different access methods would be required.
That makes the Kconfig even more complex :-(
Andrew
next prev parent reply other threads:[~2020-07-15 18:38 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 16:26 [PATCH RFC net-next] net: phy: add Marvell PHY PTP support Russell King
2020-07-15 18:38 ` Andrew Lunn [this message]
2020-07-15 18:56 ` Russell King - ARM Linux admin
2020-07-16 11:33 ` Russell King - ARM Linux admin
2020-07-16 20:53 ` Richard Cochran
2020-07-16 20:48 ` Richard Cochran
2020-07-17 7:54 ` Kurt Kanzenbach
2020-07-18 2:24 ` Richard Cochran
2020-07-20 14:21 ` Richard Cochran
2020-07-20 14:37 ` Kurt Kanzenbach
2020-07-26 23:48 ` Russell King - ARM Linux admin
2020-07-29 10:58 ` Russell King - ARM Linux admin
2020-07-29 13:19 ` Richard Cochran
2020-07-29 13:28 ` Russell King - ARM Linux admin
2020-07-29 22:07 ` Russell King - ARM Linux admin
2020-07-29 22:53 ` Vladimir Oltean
2020-07-30 15:53 ` Richard Cochran
2020-07-30 18:38 ` Russell King - ARM Linux admin
2020-07-30 19:32 ` Richard Cochran
2020-07-30 19:44 ` Russell King - ARM Linux admin
2020-07-30 11:06 ` [PATCH RFC net-next] net: phy: add Marvell PHY PTP support [multicast/DSA issues] Russell King - ARM Linux admin
2020-07-30 11:54 ` Russell King - ARM Linux admin
2020-07-30 12:47 ` Russell King - ARM Linux admin
2023-02-27 14:40 ` Köry Maincent
2023-02-27 15:20 ` Russell King (Oracle)
2023-02-27 17:30 ` Köry Maincent
2023-02-27 17:42 ` Russell King (Oracle)
2023-02-27 19:45 ` Richard Cochran
2023-02-27 20:09 ` Russell King (Oracle)
2023-02-27 20:19 ` Richard Cochran
2023-02-28 12:07 ` Russell King (Oracle)
2023-02-28 13:16 ` Köry Maincent
2023-02-28 13:36 ` Russell King (Oracle)
2023-02-28 14:50 ` Köry Maincent
2023-02-28 15:16 ` Richard Cochran
2023-02-28 15:33 ` Andrew Lunn
2023-02-28 21:13 ` Richard Cochran
2023-02-28 16:27 ` Russell King (Oracle)
2023-02-28 16:44 ` Michael Walle
2023-02-28 16:58 ` Russell King (Oracle)
2023-02-28 20:13 ` Michael Walle
2023-02-28 21:11 ` Richard Cochran
2023-02-28 21:24 ` Richard Cochran
2023-02-28 22:26 ` Jakub Kicinski
2023-02-28 22:40 ` Russell King (Oracle)
2023-02-28 22:59 ` Jakub Kicinski
2023-03-01 16:04 ` Köry Maincent
2023-03-02 4:36 ` Richard Cochran
2023-03-02 11:49 ` Russell King (Oracle)
2023-03-02 16:49 ` Jakub Kicinski
2023-03-02 17:06 ` Köry Maincent
2023-03-02 17:23 ` Jakub Kicinski
2023-03-03 13:12 ` Köry Maincent
2023-03-03 23:28 ` Jakub Kicinski
2023-03-02 17:26 ` Russell King (Oracle)
2023-03-03 10:20 ` Michael Walle
2023-03-03 13:20 ` Andrew Lunn
2023-03-03 13:34 ` Köry Maincent
2023-03-03 13:59 ` Andrew Lunn
2023-03-03 14:03 ` Russell King (Oracle)
2023-03-03 16:34 ` Andrew Lunn
2023-03-03 17:32 ` Richard Cochran
2023-03-03 17:35 ` Richard Cochran
2023-03-03 23:40 ` Jakub Kicinski
2023-03-02 21:28 ` Richard Cochran
2023-03-02 21:19 ` Richard Cochran
2023-04-27 15:13 ` Köry Maincent
2023-04-27 16:50 ` Andrew Lunn
2023-04-28 8:51 ` Köry Maincent
2020-07-30 15:50 ` Richard Cochran
2020-07-31 14:41 ` Andrew Lunn
2023-03-02 10:37 ` [PATCH RFC net-next] net: phy: add Marvell PHY PTP support Köry Maincent
2023-03-02 17:38 ` Russell King (Oracle)
2023-03-02 21:35 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715183843.GA1256692@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richardcochran@gmail$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox