Subject: Re: [PATCH net-next] bareudp: Reverted support to enable & disable rx metadata collection

From: Martin Varghese <[email-masked]>
Date: Thu, 16 Jul 2020 08:16:16 +0530

On Wed, Jul 15, 2020 at 01:43:47PM -0700, Jakub Kicinski wrote:
> On Wed, 15 Jul 2020 08:42:40 +0530 Martin Varghese wrote:
> > From: Martin Varghese <[email-masked]>
> > 
> > The commit fe80536acf83 ("bareudp: Added attribute to enable & disable
> > rx metadata collection") breaks the the original(5.7) default behavior of
> > bareudp module to collect RX metadadata at the receive. It was added to
> > avoid the crash at the kernel neighbour subsytem when packet with metadata
> > from bareudp is processed. But it is no more needed as the
> > commit 394de110a733 ("net: Added pointer check for
> > dst->ops->neigh_lookup in dst_neigh_lookup_skb") solves this crash.
> > 
> > Fixes: fe80536acf83 ("bareudp: Added attribute to enable & disable rx metadata collection")
> > Signed-off-by: Martin Varghese <[email-masked]>
> 
> Looks like you didn't remove the mention of the RX_COLLECT_METADATA
> flag from the documentation - is this intentional?

No I missed it. Thanks for pointing it out.

Thanks
Martin