Subject: Re: [PATCH net-next 0/4] cxgb4: add ethtool self_test support

From: Andrew Lunn <[email-masked]>
Date: Fri, 17 Jul 2020 20:02:51 +0200

On Fri, Jul 17, 2020 at 07:17:55PM +0530, Vishal Kulkarni wrote:
> This series of patches add support for below tests.
> 1. Adapter status test
> 2. Link test
> 3. Link speed test
> 4. Loopback test

Hi Vishal

The loopback test is pretty usual for an ethtool self test. But the
first 3 are rather odd. They don't really seem to be self tests. What
reason do you have for adding these? Are you trying to debug a
specific problem?

	 Andrew