From: Andrew Lunn <andrew@lunn•ch>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: Vladimir Oltean <olteanv@gmail•com>,
netdev@vger•kernel.org, Vivien Didelot <vivien.didelot@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Jiri Pirko <jiri@mellanox•com>,
Eric Dumazet <edumazet@google•com>,
Taehee Yoo <ap420073@gmail•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
Maxim Mikityanskiy <maximmi@mellanox•com>,
Richard Cochran <richardcochran@gmail•com>,
Michal Kubecek <mkubecek@suse•cz>,
open list <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH net-next 3/4] net: Call into DSA netdevice_ops wrappers
Date: Sun, 19 Jul 2020 18:04:41 +0200 [thread overview]
Message-ID: <20200719160441.GK1383417@lunn.ch> (raw)
In-Reply-To: <d3a11ef5-3e4e-0c4a-790b-63da94a1545c@gmail.com>
> If we have the core network stack reference DSA as a module then we
> force DSA to be either built-in or not, which is not very practical,
> people would still want a modular choice to be possible. The static
> inline only wraps indirect function pointer calls using definitions
> available at build time and actual function pointer substitution at run
> time, so we avoid that problem entirely that way.
Hi Florian
The jumping through the pointer avoids the inbuilt vs module problems.
The helpers themselves could be in a net/core/*.c file, rather than
static inline in a header. Is it worth adding a net/core/dsa.c for
code which must always be built in? At the moment, probably not. But
if we have more such redirect, maybe it would be?
Andrew
next prev parent reply other threads:[~2020-07-19 16:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 3:05 [PATCH net-next 0/4] net: dsa: Setup dsa_netdev_ops Florian Fainelli
2020-07-18 3:05 ` [PATCH net-next 1/4] net: Wrap ndo_do_ioctl() to prepare for DSA stacked ops Florian Fainelli
2020-07-18 20:30 ` Vladimir Oltean
2020-07-18 20:36 ` Florian Fainelli
2020-07-18 20:44 ` Vladimir Oltean
2020-07-19 15:31 ` Andrew Lunn
2020-07-18 3:05 ` [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops Florian Fainelli
2020-07-18 4:53 ` kernel test robot
2020-07-18 18:53 ` Florian Fainelli
2020-07-18 20:18 ` Vladimir Oltean
2020-07-18 20:20 ` Florian Fainelli
2020-07-19 15:40 ` Andrew Lunn
2020-07-19 16:10 ` Florian Fainelli
2020-07-18 3:05 ` [PATCH net-next 3/4] net: Call into DSA netdevice_ops wrappers Florian Fainelli
2020-07-18 21:18 ` Vladimir Oltean
2020-07-18 21:53 ` Florian Fainelli
2020-07-19 16:04 ` Andrew Lunn [this message]
2020-07-19 16:08 ` Florian Fainelli
2020-07-18 3:05 ` [PATCH net-next 4/4] net: dsa: Setup dsa_netdev_ops Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200719160441.GK1383417@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=ap420073@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=maximmi@mellanox$(echo .)com \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox