From: Andrew Lunn <andrew@lunn•ch>
To: "Marek Behún" <marek.behun@nic•cz>
Cc: netdev@vger•kernel.org, linux-leds@vger•kernel.org,
"Pavel Machek" <pavel@ucw•cz>,
jacek.anaszewski@gmail•com, "Dan Murphy" <dmurphy@ti•com>,
"Ondřej Jirman" <megous@megous•com>,
"Russell King" <linux@armlinux•org.uk>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin•com>,
"Gregory Clement" <gregory.clement@bootlin•com>,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH RFC leds + net-next v4 1/2] net: phy: add API for LEDs controlled by PHY HW
Date: Tue, 28 Jul 2020 18:28:16 +0200 [thread overview]
Message-ID: <20200728162816.GK1705504@lunn.ch> (raw)
In-Reply-To: <20200728171128.61c7193b@dellmb.labs.office.nic.cz>
> > @@ -736,6 +777,16 @@ struct phy_driver {
> > int (*set_loopback)(struct phy_device *dev, bool enable);
> > int (*get_sqi)(struct phy_device *dev);
> > int (*get_sqi_max)(struct phy_device *dev);
> > +
> > + /* PHY LED support */
> > + int (*led_init)(struct phy_device *dev, struct
> > phy_device_led *led);
> > + int (*led_brightness_set)(struct phy_device *dev, struct
> > phy_device_led *led,
> > + enum led_brightness brightness);
> > + const char *(*led_iter_hw_mode)(struct phy_device *dev,
> > struct phy_device_led *led,
> > + void ** iter);
> > + int (*led_set_hw_mode)(struct phy_device *dev, struct
> > phy_device_led *led,
> > + const char *mode);
> > + const char *(*led_get_hw_mode)(struct phy_device *dev,
> > struct phy_device_led *led); };
> > #define to_phy_driver(d)
> > container_of(to_mdio_common_driver(d), \ struct
> > phy_driver, mdiodrv)
>
> The problem here is that the same code will have to be added to DSA
> switch ops structure, which is not OK.
Not necessarily. DSA drivers do have access to the phydev structure.
I think putting these members into a structure is a good idea. That
structure can be part of phy_driver and initialised just like other
members. But on probing the phy, it can be copied over to the
phy_device structure. And we can provide an API which DSA drivers can
use to register there own structure of ops to be placed into
phy_device, which would call into the DSA driver.
Andrew
next prev parent reply other threads:[~2020-07-28 16:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 15:05 [PATCH RFC leds + net-next v4 0/2] Add support for LEDs on Marvell PHYs Marek Behún
2020-07-28 15:05 ` [PATCH RFC leds + net-next v4 1/2] net: phy: add API for LEDs controlled by PHY HW Marek Behún
2020-07-28 15:11 ` Marek Behún
2020-07-28 16:28 ` Andrew Lunn [this message]
2020-07-28 17:27 ` Marek Behun
2020-07-28 16:18 ` Andrew Lunn
2020-07-28 17:28 ` Marek Behun
2020-07-28 15:05 ` [PATCH RFC leds + net-next v4 2/2] net: phy: marvell: add support for PHY LEDs via LED class Marek Behún
2020-07-28 15:52 ` [PATCH RFC leds + net-next v4 0/2] Add support for LEDs on Marvell PHYs Jakub Kicinski
2020-08-07 9:06 ` Pavel Machek
2020-08-07 13:29 ` Andrew Lunn
2020-08-29 22:43 ` Pavel Machek
2020-08-29 23:36 ` Andrew Lunn
2020-08-30 1:50 ` Andrew Lunn
2020-08-30 9:22 ` Pavel Machek
2020-08-25 8:13 ` Matthias Schiffer
2020-08-30 22:56 ` Marek Behun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728162816.GK1705504@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=dmurphy@ti$(echo .)com \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=jacek.anaszewski@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=marek.behun@nic$(echo .)cz \
--cc=megous@megous$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pavel@ucw$(echo .)cz \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox