Subject: Re: [PATCH net-next 3/6] vxlan: Support for PMTU discovery on directly bridged links

From: Stefano Brivio <[email-masked]>
Date: Tue, 4 Aug 2020 07:53:29 +0200

On Mon, 3 Aug 2020 17:48:48 -0600
David Ahern <[email-masked]> wrote:

> On 8/3/20 2:52 PM, Stefano Brivio wrote:
> > +		err = skb_tunnel_check_pmtu(skb, ndst, VXLAN_HEADROOM,
> > +					    netif_is_bridge_port(dev) ||
> > +					    netif_is_ovs_port(dev));  
> 
> you have this check in a few places. Maybe a new helper like
> netif_is_any_bridge_port that can check both IFF flags in 1 go.

Ah, yes, good idea, added to 1/6 v2 as it's where it's needed now.

-- 
Stefano