public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen•de>
To: Tong Zhang <ztong0001@gmail•com>
Cc: pablo@netfilter•org, kadlec@netfilter•org, fw@strlen•de,
	davem@davemloft•net, kuba@kernel•org,
	netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
	netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error
Date: Sun, 16 Aug 2020 00:50:00 +0200	[thread overview]
Message-ID: <20200815225000.GI1660@breakpoint.cc> (raw)
In-Reply-To: <20200815165030.5849-1-ztong0001@gmail.com>

Tong Zhang <ztong0001@gmail•com> wrote:
> ct_sip_parse_numerical_param can only return 0 or 1, but the caller is
> checking parsing error using < 0

Reviewed-by: Florian Westphal <fw@strlen•de>

  reply	other threads:[~2020-08-15 22:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-15 16:50 [PATCH] netfilter: nf_conntrack_sip: fix parsing error Tong Zhang
2020-08-15 22:50 ` Florian Westphal [this message]
2020-08-28 18:07 ` Pablo Neira Ayuso
2020-08-28 18:14   ` Tong Zhang
2020-08-28 18:19     ` Pablo Neira Ayuso
2020-08-28 18:30       ` Tong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200815225000.GI1660@breakpoint.cc \
    --to=fw@strlen$(echo .)de \
    --cc=coreteam@netfilter$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=kadlec@netfilter$(echo .)org \
    --cc=kuba@kernel$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=netfilter-devel@vger$(echo .)kernel.org \
    --cc=pablo@netfilter$(echo .)org \
    --cc=ztong0001@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox