public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber•org>
To: Leon Romanovsky <leon@kernel•org>
Cc: David Ahern <dsahern@gmail•com>,
	Leon Romanovsky <leonro@nvidia•com>,
	Doug Ledford <dledford@redhat•com>,
	Jason Gunthorpe <jgg@nvidia•com>,
	linux-netdev <netdev@vger•kernel.org>,
	RDMA mailing list <linux-rdma@vger•kernel.org>
Subject: Re: [PATCH iproute2-rc v1 2/2] rdma: Properly print device and link names in CLI output
Date: Sun, 16 Aug 2020 15:48:46 -0700	[thread overview]
Message-ID: <20200816154846.63ebf57c@hermes.lan> (raw)
In-Reply-To: <20200811073201.663398-3-leon@kernel.org>

On Tue, 11 Aug 2020 10:32:01 +0300
Leon Romanovsky <leon@kernel•org> wrote:

> +	print_color_string(PRINT_ANY, COLOR_NONE, "ifname", "dev %s ", name);

Since this is an interface name, you might want to consider using COLOR_IFNAME?

I will go ahead and apply it as is but more work is needed here.

  reply	other threads:[~2020-08-16 22:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11  7:31 [PATCH iproute2-rc v1 0/2] Fix rdmatool JSON conversion Leon Romanovsky
2020-08-11  7:32 ` [PATCH iproute2-rc v1 1/2] rdma: Fix owner name for the kernel resources Leon Romanovsky
2020-08-11  7:32 ` [PATCH iproute2-rc v1 2/2] rdma: Properly print device and link names in CLI output Leon Romanovsky
2020-08-16 22:48   ` Stephen Hemminger [this message]
2020-08-17  7:44     ` Leon Romanovsky
2020-08-16  7:58 ` [PATCH iproute2-rc v1 0/2] Fix rdmatool JSON conversion Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200816154846.63ebf57c@hermes.lan \
    --to=stephen@networkplumber$(echo .)org \
    --cc=dledford@redhat$(echo .)com \
    --cc=dsahern@gmail$(echo .)com \
    --cc=jgg@nvidia$(echo .)com \
    --cc=leon@kernel$(echo .)org \
    --cc=leonro@nvidia$(echo .)com \
    --cc=linux-rdma@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox