Subject: Re: [PATCH v4 1/9] ptp: Add generic ptp v2 header parsing function

From: Russell King - ARM Linux admin <[email-masked]>
Date: Tue, 18 Aug 2020 11:37:58 +0100

On Tue, Aug 18, 2020 at 12:32:43PM +0200, Kurt Kanzenbach wrote:
> Reason: A lot of the ptp drivers - which implement hardware time stamping - need
> specific fields such as the sequence id from the ptp v2 header. Currently all
> drivers implement that themselves.
> 
> Introduce a generic function to retrieve a pointer to the start of the ptp v2
> header.
> 
> Suggested-by: Russell King <[email-masked]>
> Signed-off-by: Kurt Kanzenbach <[email-masked]>
> Reviewed-by: Richard Cochran <[email-masked]>
> Reviewed-by: Florian Fainelli <[email-masked]>

Just one small nit, see below.  Otherwise,

Reviewed-by: Russell King <[email-masked]>

> +/**
> + * ptp_parse_header - Get pointer to the PTP v2 header
> + * @skb: packet buffer
> + * @type: type of the packet (see ptp_classify_raw())
> + *
> + * This function takes care of the VLAN, UDP, IPv4 and IPv6 headers. The length
> + * is checked.
> + *
> + * Note, internally skb_mac_header() is used. Make sure, that the @skb is
> + * initialized accordingly.

No need for the "," there - these aren't separate clauses.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!