Subject: Re: [PATCH net 4/4] sfc: don't free_irq()s if they were never requested

From: Jesse Brandeburg <[email-masked]>
Date: Tue, 18 Aug 2020 12:03:19 -0700

Edward Cree wrote:

> If efx_nic_init_interrupt fails, or was never run (e.g. due to an earlier
>  failure in ef100_net_open), freeing irqs in efx_nic_fini_interrupt is not
>  needed and will cause error messages and stack traces.
> So instead, only do this if efx_nic_init_interrupt successfully completed,
>  as indicated by the new efx->irqs_hooked flag.
> 
> Fixes: 965b549f3c20 ("sfc_ef100: implement ndo_open/close and EVQ probing")
> Signed-off-by: Edward Cree <[email-masked]>

Makes sense.
Reviewed-by: Jesse Brandeburg <[email-masked]>