From: Jesse Brandeburg <jesse.brandeburg@intel•com>
To: Ganji Aravind <ganji.aravind@chelsio•com>
Cc: <netdev@vger•kernel.org>, <davem@davemloft•net>,
<vishal@chelsio•com>, <rahul.lakkireddy@chelsio•com>
Subject: Re: [PATCH net 1/2] cxgb4: Fix work request size calculation for loopback test
Date: Tue, 18 Aug 2020 12:33:45 -0700 [thread overview]
Message-ID: <20200818123345.00007802@intel.com> (raw)
In-Reply-To: <20200818154058.1770002-2-ganji.aravind@chelsio.com>
Ganji Aravind wrote:
> Work request used for sending loopback packet needs to add
> the firmware work request only once. So, fix by using
> correct structure size.
>
> Fixes: 7235ffae3d2c ("cxgb4: add loopback ethtool self-test")
> Signed-off-by: Ganji Aravind <ganji.aravind@chelsio•com>
changes look ok, but to understand why this change fixed the bug, you
could have just mentioned that the cpl_tx_pkt struct has a _core member
inside of it, and then I wouldn't have had to waste review time digging
through the code in the kernel.
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel•com>
next prev parent reply other threads:[~2020-08-18 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 15:40 [PATCH net 0/2]cxgb4: Fix ethtool selftest flits calculation Ganji Aravind
2020-08-18 15:40 ` [PATCH net 1/2] cxgb4: Fix work request size calculation for loopback test Ganji Aravind
2020-08-18 19:33 ` Jesse Brandeburg [this message]
2020-08-18 15:40 ` [PATCH net 2/2] cxgb4: Fix race between loopback and normal Tx path Ganji Aravind
2020-08-18 19:35 ` Jesse Brandeburg
2020-08-18 20:03 ` [PATCH net 0/2]cxgb4: Fix ethtool selftest flits calculation David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818123345.00007802@intel.com \
--to=jesse.brandeburg@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ganji.aravind@chelsio$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rahul.lakkireddy@chelsio$(echo .)com \
--cc=vishal@chelsio$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox