Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error

From: Pablo Neira Ayuso <[email-masked]>
Date: Fri, 28 Aug 2020 20:07:42 +0200

On Sat, Aug 15, 2020 at 12:50:30PM -0400, Tong Zhang wrote:
> ct_sip_parse_numerical_param can only return 0 or 1, but the caller is
> checking parsing error using < 0

Is this are real issue in your setup or probably some static analysis
tool is reporting?

You are right that ct_sip_parse_numerical_param() never returns < 0,
however, looking at:

https://tools.ietf.org/html/rfc3261 see Page 161

expires is optional, my understanding is that your patch is making
this option mandatory.