From: Andrew Lunn <andrew@lunn•ch>
To: Russell King <rmk+kernel@armlinux•org.uk>
Cc: Alexandre Belloni <alexandre.belloni@bootlin•com>,
Antoine Tenart <antoine.tenart@bootlin•com>,
Richard Cochran <richardcochran@gmail•com>,
Matteo Croce <mcroce@redhat•com>,
Andre Przywara <andre.przywara@arm•com>,
Sven Auhagen <sven.auhagen@voleatech•de>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next 6/7] net: mvpp2: ptp: add interrupt handling
Date: Thu, 3 Sep 2020 03:39:40 +0200 [thread overview]
Message-ID: <20200903013940.GA3090178@lunn.ch> (raw)
In-Reply-To: <E1kDVMg-0000k9-6g@rmk-PC.armlinux.org.uk>
> +static void mvpp2_isr_handle_ptp_queue(struct mvpp2_port *port, int nq)
> +{
> + void __iomem *ptp_q;
> + u32 r0, r1, r2;
> +
> + ptp_q = port->priv->iface_base + MVPP22_PTP_BASE(port->gop_id);
> + if (nq)
> + ptp_q += MVPP22_PTP_TX_Q1_R0 - MVPP22_PTP_TX_Q0_R0;
> +
> + while (1) {
> + r0 = readl_relaxed(ptp_q + MVPP22_PTP_TX_Q0_R0) & 0xffff;
> + if (!r0)
> + break;
> +
> + r1 = readl_relaxed(ptp_q + MVPP22_PTP_TX_Q0_R1) & 0xffff;
> + r2 = readl_relaxed(ptp_q + MVPP22_PTP_TX_Q0_R2) & 0xffff;
> + }
> +}
Hi Russell
That is a rather odd interrupt handler, basically throwing everything
away. Maybe add a comment about what is going on?
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2020-09-03 1:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 16:10 [PATCH net-next 0/7] Marvell PP2.2 PTP support Russell King - ARM Linux admin
2020-09-02 16:11 ` [PATCH net-next 1/7] net: mvpp2: restructure "link status" interrupt handling Russell King
2020-09-03 1:16 ` Andrew Lunn
2020-09-02 16:11 ` [PATCH net-next 2/7] net: mvpp2: rename mis-named "link status" interrupt Russell King
2020-09-03 1:17 ` Andrew Lunn
2020-09-02 16:11 ` [PATCH net-next 3/7] net: mvpp2: check first level interrupt status registers Russell King
2020-09-03 1:24 ` Andrew Lunn
2020-09-04 7:26 ` Russell King - ARM Linux admin
2020-09-02 16:11 ` [PATCH net-next 4/7] net: mvpp2: ptp: add TAI support Russell King
2020-09-02 16:11 ` [PATCH net-next 5/7] net: mvpp2: ptp: add support for receive timestamping Russell King
2020-09-02 16:12 ` [PATCH net-next 6/7] net: mvpp2: ptp: add interrupt handling Russell King
2020-09-03 1:39 ` Andrew Lunn [this message]
2020-09-03 8:48 ` Russell King - ARM Linux admin
2020-09-03 20:38 ` Andrew Lunn
2020-09-02 16:12 ` [PATCH net-next 7/7] net: mvpp2: ptp: add support for transmit timestamping Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903013940.GA3090178@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andre.przywara@arm$(echo .)com \
--cc=antoine.tenart@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=mcroce@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richardcochran@gmail$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=sven.auhagen@voleatech$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox