From: Krzysztof Kozlowski <krzk@kernel•org>
To: "David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Rob Herring <robh+dt@kernel•org>,
Krzysztof Kozlowski <krzk@kernel•org>,
Krzysztof Opasiak <k.opasiak@samsung•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will@kernel•org>, Olof Johansson <olof@lixom•net>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
devicetree@vger•kernel.org, linux-nfc@lists•01.org,
linux-arm-kernel@lists•infradead.org,
linux-samsung-soc@vger•kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung•com>,
Arnd Bergmann <arnd@arndb•de>
Subject: [PATCH v2 4/9] nfc: s3fwrn5: Remove unneeded 'ret' variable
Date: Sun, 6 Sep 2020 17:36:49 +0200 [thread overview]
Message-ID: <20200906153654.2925-5-krzk@kernel.org> (raw)
In-Reply-To: <20200906153654.2925-1-krzk@kernel.org>
The local variable 'ret' can be removed:
drivers/nfc/s3fwrn5/i2c.c:167:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
Signed-off-by: Krzysztof Kozlowski <krzk@kernel•org>
---
drivers/nfc/s3fwrn5/i2c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c
index 557279492503..dc995286be84 100644
--- a/drivers/nfc/s3fwrn5/i2c.c
+++ b/drivers/nfc/s3fwrn5/i2c.c
@@ -164,7 +164,6 @@ static int s3fwrn5_i2c_read(struct s3fwrn5_i2c_phy *phy)
static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
{
struct s3fwrn5_i2c_phy *phy = phy_id;
- int ret = 0;
if (!phy || !phy->ndev) {
WARN_ON_ONCE(1);
@@ -179,10 +178,9 @@ static irqreturn_t s3fwrn5_i2c_irq_thread_fn(int irq, void *phy_id)
switch (phy->mode) {
case S3FWRN5_MODE_NCI:
case S3FWRN5_MODE_FW:
- ret = s3fwrn5_i2c_read(phy);
+ s3fwrn5_i2c_read(phy);
break;
case S3FWRN5_MODE_COLD:
- ret = -EREMOTEIO;
break;
}
--
2.17.1
next prev parent reply other threads:[~2020-09-06 15:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 15:36 [PATCH v2 0/9] nfc: s3fwrn5: Few cleanups Krzysztof Kozlowski
2020-09-06 15:36 ` [PATCH v2 1/9] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Krzysztof Kozlowski
2020-09-08 19:45 ` Rob Herring
2020-09-10 10:53 ` Krzysztof Kozlowski
2020-09-06 15:36 ` [PATCH v2 2/9] dt-bindings: net: nfc: s3fwrn5: Remove wrong vendor prefix from GPIOs Krzysztof Kozlowski
2020-09-06 15:36 ` [PATCH v2 3/9] " Krzysztof Kozlowski
2020-09-06 15:36 ` Krzysztof Kozlowski [this message]
2020-09-06 15:36 ` [PATCH v2 5/9] nfc: s3fwrn5: Add missing CRYPTO_HASH dependency Krzysztof Kozlowski
2020-09-06 15:36 ` [PATCH v2 6/9] nfc: s3fwrn5: Constify s3fwrn5_fw_info when not modified Krzysztof Kozlowski
2020-09-06 15:36 ` [PATCH v2 7/9] MAINTAINERS: Add Krzysztof Kozlowski to Samsung S3FWRN5 and remove Robert Krzysztof Kozlowski
2020-09-06 15:36 ` [PATCH v2 8/9] arm64: dts: exynos: Use newer S3FWRN5 GPIO properties in Exynos5433 TM2 Krzysztof Kozlowski
2020-09-06 15:36 ` [PATCH v2 9/9] arm64: defconfig: Enable Samsung S3FWRN5 NFC driver Krzysztof Kozlowski
2020-09-10 16:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200906153654.2925-5-krzk@kernel.org \
--to=krzk@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=k.opasiak@samsung$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfc@lists$(echo .)01.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olof@lixom$(echo .)net \
--cc=robh+dt@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox