Subject: Re: [PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries

From: Andrew Lunn <[email-masked]>
Date: Tue, 15 Sep 2020 22:10:14 +0200

On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote:
> @@ -160,6 +160,8 @@ static const struct phy_setting settings[] = {
>  	PHY_SETTING(    100, FULL,    100baseT_Full		),
>  	PHY_SETTING(    100, FULL,    100baseT1_Full		),
>  	PHY_SETTING(    100, HALF,    100baseT_Half		),
> +	PHY_SETTING(    100, HALF,    100baseFX_Half		),
> +	PHY_SETTING(    100, FULL,    100baseFX_Full		),

Hi Dan

Does 100baseFX_Half make an sense? My understanding of 802.3 section
26 is that it is always a pair, not a single fibre where you might
need CSMA/CD?

   Andrew