Subject: Re: [PATCH net-next 05/11] net: dsa: seville: remove unused defines for the mdio controller

From: Alexandre Belloni <[email-masked]>
Date: Fri, 18 Sep 2020 19:37:19 +0200

On 18/09/2020 18:54:42+0300, Vladimir Oltean wrote:
> On Fri, Sep 18, 2020 at 05:46:45PM +0200, Alexandre Belloni wrote:
> > On 18/09/2020 13:57:47+0300, Vladimir Oltean wrote:
> > > From: Vladimir Oltean <[email-masked]>
> > >
> > > Some definitions were likely copied from
> > > drivers/net/mdio/mdio-mscc-miim.c.
> > >
> > > They are not necessary, remove them.
> >
> > Seeing that the mdio controller is probably the same, couldn't
> > mdio-mscc-miim be reused?
> 
> Yeah, it probably can, but for 75 lines of code, is it worth it to
> butcher mdio-mscc-miim too? I'm not sure at what level that reuse should
> be. Should we pass it our regmap? mdio-mscc-miim doesn't use regmap.

It may be worth it, I'm going to add DSA support for ocelot over SPI. So
to abstract the bus, it is probably worth moving to regmap.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com