From: Andrew Lunn <andrew@lunn•ch>
To: Linus Walleij <linus.walleij@linaro•org>
Cc: Vivien Didelot <vivien.didelot@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
netdev@vger•kernel.org, "David S . Miller" <davem@davemloft•net>
Subject: Re: [PATCH] net: dsa: rtl8366rb: Roof MTU for switch
Date: Sun, 20 Sep 2020 02:07:46 +0200 [thread overview]
Message-ID: <20200920000746.GA3673389@lunn.ch> (raw)
In-Reply-To: <20200919220105.311483-1-linus.walleij@linaro.org>
> static int rtl8366rb_setup(struct dsa_switch *ds)
> {
> struct realtek_smi *smi = ds->priv;
> + struct rtl8366rb *rb = smi->chip_data;
> const u16 *jam_table;
> u32 chip_ver = 0;
> u32 chip_id = 0;
Hi Linus
Reverse Christmas tree means you need to do the assignment later.
Otherwise this looks O.K.
Andrew
next prev parent reply other threads:[~2020-09-20 0:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 22:01 [PATCH] net: dsa: rtl8366rb: Roof MTU for switch Linus Walleij
2020-09-20 0:07 ` Andrew Lunn [this message]
2020-09-21 21:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200920000746.GA3673389@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox