Subject: Re: [PATCH 1/2] net: qrtr: Allow forwarded services

From: Bjorn Andersson <[email-masked]>
Date: Tue, 29 Sep 2020 09:34:19 -0500

On Tue 29 Sep 08:33 CDT 2020, Loic Poulain wrote:

> A remote endpoint (immediate neighbor node) can forward services
> from other non-immediate nodes, in that case ctrl packet node ID
> (offering distant service) can differ from the qrtr source node
> (forwarding the packet).
> 
> Signed-off-by: Loic Poulain <[email-masked]>

Reviewed-by: Bjorn Andersson <[email-masked]>

Regards,
Bjorn

> ---
>  net/qrtr/ns.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c
> index d8252fd..d542d8f 100644
> --- a/net/qrtr/ns.c
> +++ b/net/qrtr/ns.c
> @@ -469,10 +469,6 @@ static int ctrl_cmd_new_server(struct sockaddr_qrtr *from,
>  		port = from->sq_port;
>  	}
>  
> -	/* Don't accept spoofed messages */
> -	if (from->sq_node != node_id)
> -		return -EINVAL;
> -
>  	srv = server_add(service, instance, node_id, port);
>  	if (!srv)
>  		return -EINVAL;
> @@ -511,10 +507,6 @@ static int ctrl_cmd_del_server(struct sockaddr_qrtr *from,
>  		port = from->sq_port;
>  	}
>  
> -	/* Don't accept spoofed messages */
> -	if (from->sq_node != node_id)
> -		return -EINVAL;
> -
>  	/* Local servers may only unregister themselves */
>  	if (from->sq_node == qrtr_ns.local_node && from->sq_port != port)
>  		return -EINVAL;
> -- 
> 2.7.4
>