From: kernel test robot <lkp@intel•com>
To: Xin Long <lucien.xin@gmail•com>,
network dev <netdev@vger•kernel.org>,
linux-sctp@vger•kernel.org
Cc: kbuild-all@lists•01.org,
Marcelo Ricardo Leitner <marcelo.leitner@gmail•com>,
Neil Horman <nhorman@tuxdriver•com>,
Michael Tuexen <tuexen@fh-muenster•de>,
Tom Herbert <therbert@google•com>,
davem@davemloft•net
Subject: Re: [PATCH net-next 11/15] sctp: add udphdr to overhead when udp_port is set
Date: Wed, 30 Sep 2020 03:00:42 +0800 [thread overview]
Message-ID: <202009300218.2AcHEN0L-lkp@intel.com> (raw)
In-Reply-To: <7ff312f910ada8893fa4db57d341c628d1122640.1601387231.git.lucien.xin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2506 bytes --]
Hi Xin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20200929-215159
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 280095713ce244e8dbdfb059cdca695baa72230a
config: c6x-randconfig-r023-20200929 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/38f71b63a83947b86b356d8af1ba077027d27deb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20200929-215159
git checkout 38f71b63a83947b86b356d8af1ba077027d27deb
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel•com>
All errors (new ones prefixed by >>):
In file included from include/net/sctp/checksum.h:27,
from net/netfilter/nf_nat_proto.c:16:
include/net/sctp/sctp.h: In function 'sctp_mtu_payload':
>> include/net/sctp/sctp.h:583:31: error: 'struct net' has no member named 'sctp'; did you mean 'ct'?
583 | if (sock_net(&sp->inet.sk)->sctp.udp_port)
| ^~~~
| ct
vim +583 include/net/sctp/sctp.h
572
573 /* Calculate max payload size given a MTU, or the total overhead if
574 * given MTU is zero
575 */
576 static inline __u32 sctp_mtu_payload(const struct sctp_sock *sp,
577 __u32 mtu, __u32 extra)
578 {
579 __u32 overhead = sizeof(struct sctphdr) + extra;
580
581 if (sp) {
582 overhead += sp->pf->af->net_header_len;
> 583 if (sock_net(&sp->inet.sk)->sctp.udp_port)
584 overhead += sizeof(struct udphdr);
585 } else {
586 overhead += sizeof(struct ipv6hdr);
587 }
588
589 if (WARN_ON_ONCE(mtu && mtu <= overhead))
590 mtu = overhead;
591
592 return mtu ? mtu - overhead : overhead;
593 }
594
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27152 bytes --]
next prev parent reply other threads:[~2020-09-29 19:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 13:48 [PATCH net-next 00/15] sctp: Implement RFC6951: UDP Encapsulation of SCTP Xin Long
2020-09-29 13:48 ` [PATCH net-next 01/15] udp: check udp sock encap_type in __udp_lib_err Xin Long
2020-09-29 13:48 ` [PATCH net-next 02/15] udp6: move the mss check after udp gso tunnel processing Xin Long
2020-09-29 13:48 ` [PATCH net-next 03/15] udp: do checksum properly in skb_udp_tunnel_segment Xin Long
2020-10-03 4:04 ` Marcelo Ricardo Leitner
2020-10-03 7:40 ` Xin Long
2020-09-29 13:48 ` [PATCH net-next 04/15] udp: support sctp over udp " Xin Long
2020-09-29 13:48 ` [PATCH net-next 05/15] sctp: create udp4 sock and add its encap_rcv Xin Long
2020-09-29 13:48 ` [PATCH net-next 06/15] sctp: create udp6 sock and set " Xin Long
2020-09-29 13:48 ` [PATCH net-next 07/15] sctp: add encap_err_lookup for udp encap socks Xin Long
2020-09-29 13:49 ` [PATCH net-next 08/15] sctp: add encap_port for netns sock asoc and transport Xin Long
2020-09-29 13:49 ` [PATCH net-next 09/15] sctp: add SCTP_REMOTE_UDP_ENCAPS_PORT sockopt Xin Long
2020-10-03 4:05 ` Marcelo Ricardo Leitner
2020-10-03 7:41 ` Xin Long
2020-09-29 13:49 ` [PATCH net-next 10/15] sctp: allow changing transport encap_port by peer packets Xin Long
2020-10-03 4:06 ` Marcelo Ricardo Leitner
2020-09-29 13:49 ` [PATCH net-next 11/15] sctp: add udphdr to overhead when udp_port is set Xin Long
2020-09-29 19:00 ` kernel test robot [this message]
2020-10-03 4:08 ` Marcelo Ricardo Leitner
2020-10-03 8:12 ` Xin Long
2020-10-03 11:23 ` Xin Long
2020-10-03 12:24 ` Xin Long
2020-10-05 19:01 ` Marcelo Ricardo Leitner
2020-10-05 20:08 ` Michael Tuexen
2020-10-08 9:37 ` Xin Long
2020-10-03 4:07 ` Marcelo Ricardo Leitner
2020-10-03 7:54 ` Xin Long
2020-09-29 13:49 ` [PATCH net-next 12/15] sctp: call sk_setup_caps in sctp_packet_transmit instead Xin Long
2020-10-03 4:09 ` Marcelo Ricardo Leitner
2020-10-03 7:45 ` Xin Long
2020-09-29 13:49 ` [PATCH net-next 13/15] sctp: support for sending packet over udp4 sock Xin Long
2020-09-29 16:25 ` kernel test robot
2020-09-30 6:26 ` Xin Long
2020-09-29 19:19 ` kernel test robot
2020-09-29 13:49 ` [PATCH net-next 14/15] sctp: support for sending packet over udp6 sock Xin Long
2020-09-29 13:49 ` [PATCH net-next 15/15] sctp: enable udp tunneling socks Xin Long
2020-10-03 4:12 ` Marcelo Ricardo Leitner
2020-10-03 8:20 ` Xin Long
2020-09-29 16:39 ` [PATCH net-next 00/15] sctp: Implement RFC6951: UDP Encapsulation of SCTP Michael Tuexen
2020-09-29 18:04 ` Xin Long
2020-10-01 12:41 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009300218.2AcHEN0L-lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kbuild-all@lists$(echo .)01.org \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=therbert@google$(echo .)com \
--cc=tuexen@fh-muenster$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox