From: Tom Parkin <tparkin@katalix•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: netdev@vger•kernel.org, jchapman@katalix•com
Subject: Re: [PATCH net-next 5/6] l2tp: add ac_pppoe pseudowire driver
Date: Thu, 1 Oct 2020 17:24:53 +0100 [thread overview]
Message-ID: <20201001162453.GB4708@katalix.com> (raw)
In-Reply-To: <20201001075640.16212741@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]
On Thu, Oct 01, 2020 at 07:56:40 -0700, Jakub Kicinski wrote:
> On Wed, 30 Sep 2020 22:07:06 +0100 Tom Parkin wrote:
> > The AC/PPPoE driver implements pseudowire type L2TP_PWTYPE_PPP_AC, for
> > use in a PPPoE Access Concentrator configuration. Rather than
> > terminating the PPP session locally, the AC/PPPoE driver forwards PPP
> > packets over an L2TP tunnel for termination at the LNS.
> >
> > l2tp_ac_pppoe provides a data path for PPPoE session packets, and
> > should be instantiated once a userspace process has completed the PPPoE
> > discovery process.
> >
> > To create an instance of an L2TP_PWTYPE_PPP_AC pseudowire, userspace
> > must use the L2TP_CMD_SESSION_CREATE netlink command, and pass the
> > following attributes:
> >
> > * L2TP_ATTR_IFNAME, to specify the name of the interface associated
> > with the PPPoE session;
> > * L2TP_ATTR_PPPOE_SESSION_ID, to specify the PPPoE session ID assigned
> > to the session;
> > * L2TP_ATTR_PPPOE_PEER_MAC_ADDR, to specify the MAC address of the
> > PPPoE peer
>
> C=1 generates:
>
> net/l2tp/l2tp_ac_pppoe.c:234:20: warning: incorrect type in argument 1 (different address spaces)
> net/l2tp/l2tp_ac_pppoe.c:234:20: expected struct net_device *dev
> net/l2tp/l2tp_ac_pppoe.c:234:20: got struct net_device [noderef] __rcu *dev
> net/l2tp/l2tp_ac_pppoe.c:380:45: error: incompatible types in comparison expression (different address spaces):
> net/l2tp/l2tp_ac_pppoe.c:380:45: struct net_device [noderef] __rcu *
> net/l2tp/l2tp_ac_pppoe.c:380:45: struct net_device *
Thanks Jakub, and apologies for that slipping through. My Sparse
installation on Ubuntu wasn't working -- I've updated it now and can
see the error you reported.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-10-01 16:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 21:07 [PATCH net-next 0/6] l2tp: add ac/pppoe driver Tom Parkin
2020-09-30 21:07 ` [PATCH net-next 1/6] l2tp: add netlink info to session create callback Tom Parkin
2020-09-30 21:07 ` [PATCH net-next 2/6] l2tp: tweak netlink session create to allow L2TPv2 ac_pppoe Tom Parkin
2020-09-30 21:07 ` [PATCH net-next 3/6] l2tp: allow v2 netlink session create to pass ifname attribute Tom Parkin
2020-09-30 21:07 ` [PATCH net-next 4/6] l2tp: add netlink attributes for ac_ppp session creation Tom Parkin
2020-09-30 21:07 ` [PATCH net-next 5/6] l2tp: add ac_pppoe pseudowire driver Tom Parkin
2020-10-01 14:56 ` Jakub Kicinski
2020-10-01 16:24 ` Tom Parkin [this message]
2020-09-30 21:07 ` [PATCH net-next 6/6] docs: networking: update l2tp.rst to document PPP_AC pseudowires Tom Parkin
2020-10-01 8:59 ` [PATCH net-next 0/6] l2tp: add ac/pppoe driver James Chapman
2020-10-01 12:26 ` Guillaume Nault
2020-10-01 14:57 ` Tom Parkin
2020-10-01 18:30 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001162453.GB4708@katalix.com \
--to=tparkin@katalix$(echo .)com \
--cc=jchapman@katalix$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox