From: Mike Rapoport <rppt@kernel•org>
To: Randy Dunlap <rdunlap@infradead•org>
Cc: Muchun Song <songmuchun@bytedance•com>,
Eric Dumazet <eric.dumazet@gmail•com>,
Eric Dumazet <edumazet@google•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
Greg KH <gregkh@linuxfoundation•org>,
rafael@kernel•org, "Michael S. Tsirkin" <mst@redhat•com>,
Jason Wang <jasowang@redhat•com>,
David Miller <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Alexey Dobriyan <adobriyan@gmail•com>,
Andrew Morton <akpm@linux-foundation•org>,
Alexey Kuznetsov <kuznet@ms2•inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
Steffen Klassert <steffen.klassert@secunet•com>,
Herbert Xu <herbert@gondor•apana.org.au>,
Shakeel Butt <shakeelb@google•com>, Will Deacon <will@kernel•org>,
Michal Hocko <mhocko@suse•com>, Roman Gushchin <guro@fb•com>,
Neil Brown <neilb@suse•de>,
Sami Tolvanen <samitolvanen@google•com>,
"Kirill A. Shutemov" <kirill.shutemov@linux•intel.com>,
Feng Tang <feng.tang@intel•com>, Paolo Abeni <pabeni@redhat•com>,
Willem de Bruijn <willemb@google•com>,
Florian Westphal <fw@strlen•de>,
gustavoars@kernel•org, Pablo Neira Ayuso <pablo@netfilter•org>,
Dexuan Cui <decui@microsoft•com>,
Jakub Sitnicki <jakub@cloudflare•com>,
Peter Zijlstra <peterz@infradead•org>,
Christian Brauner <christian.brauner@ubuntu•com>,
"Eric W. Biederman" <ebiederm@xmission•com>,
Thomas Gleixner <tglx@linutronix•de>,
dave@stgolabs•net, Michel Lespinasse <walken@google•com>,
Jann Horn <jannh@google•com>,
chenqiwu@xiaomi•com, christophe.leroy@c-s•fr,
Minchan Kim <minchan@kernel•org>, Martin KaFai Lau <kafai@fb•com>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Miaohe Lin <linmiaohe@huawei•com>,
Kees Cook <keescook@chromium•org>,
LKML <linux-kernel@vger•kernel.org>,
virtualization@lists•linux-foundation.org,
Linux Kernel Network Developers <netdev@vger•kernel.org>,
linux-fsdevel <linux-fsdevel@vger•kernel.org>,
linux-mm <linux-mm@kvack•org>,
Michael Kerrisk <mtk.manpages@gmail•com>
Subject: Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo
Date: Tue, 13 Oct 2020 18:12:15 +0300 [thread overview]
Message-ID: <20201013151215.GG4251@kernel.org> (raw)
In-Reply-To: <e059f4b1-e51b-0277-e96b-c178d0cf4fd7@infradead.org>
On Tue, Oct 13, 2020 at 07:43:59AM -0700, Randy Dunlap wrote:
> On 10/13/20 1:09 AM, Mike Rapoport wrote:
> > On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote:
> >> On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet <eric.dumazet@gmail•com> wrote:
> >>>
> >>> On 10/12/20 10:39 AM, Muchun Song wrote:
> >>>> On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet <edumazet@google•com> wrote:
> >>
> >> We are not complaining about TCP using too much memory, but how do
> >> we know that TCP uses a lot of memory. When I firstly face this problem,
> >> I do not know who uses the 25GB memory and it is not shown in the /proc/meminfo.
> >> If we can know the amount memory of the socket buffer via /proc/meminfo, we
> >> may not need to spend a lot of time troubleshooting this problem. Not everyone
> >> knows that a lot of memory may be used here. But I believe many people
> >> should know /proc/meminfo to confirm memory users.
> >
> > If I undestand correctly, the problem you are trying to solve is to
> > simplify troubleshooting of memory usage for people who may not be aware
> > that networking stack can be a large memory consumer.
> >
> > For that a paragraph in 'man 5 proc' maybe a good start:
> >
> >>From ddbcf38576d1a2b0e36fe25a27350d566759b664 Mon Sep 17 00:00:00 2001
> > From: Mike Rapoport <rppt@linux•ibm.com>
> > Date: Tue, 13 Oct 2020 11:07:35 +0300
> > Subject: [PATCH] proc.5: meminfo: add not anout network stack memory
> > consumption
> >
> > Signed-off-by: Mike Rapoport <rppt@linux•ibm.com>
> > ---
> > man5/proc.5 | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/man5/proc.5 b/man5/proc.5
> > index ed309380b..8414676f1 100644
> > --- a/man5/proc.5
> > +++ b/man5/proc.5
> > @@ -3478,6 +3478,14 @@ Except as noted below,
> > all of the fields have been present since at least Linux 2.6.0.
> > Some fields are displayed only if the kernel was configured
> > with various options; those dependencies are noted in the list.
> > +.IP
> > +Note that significant part of memory allocated by the network stack
> > +is not accounted in the file.
> > +The memory consumption of the network stack can be queried
> > +using
> > +.IR /proc/net/sockstat
> > +or
> > +.BR ss (8)
> > .RS
> > .TP
> > .IR MemTotal " %lu"
>
> Hi Mike,
>
> Could you tell us what units those values are in?
> or is that already explained somewhere else?
It is described a few lines above and anyway, "MemTotal" is a part of
the diff context ;-)
> thanks.
> --
> ~Randy
>
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-10-13 15:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 10:38 [PATCH] mm: proc: add Sock to /proc/meminfo Muchun Song
2020-10-10 16:36 ` Randy Dunlap
2020-10-11 4:42 ` [External] " Muchun Song
2020-10-11 13:52 ` Mike Rapoport
2020-10-11 16:00 ` [External] " Muchun Song
2020-10-11 18:39 ` Cong Wang
2020-10-12 4:22 ` [External] " Muchun Song
2020-10-12 7:42 ` Eric Dumazet
2020-10-12 8:39 ` Muchun Song
2020-10-12 9:24 ` Eric Dumazet
2020-10-12 9:53 ` Muchun Song
2020-10-12 22:12 ` Cong Wang
2020-10-13 3:52 ` Muchun Song
2020-10-13 6:55 ` Eric Dumazet
2020-10-13 8:09 ` Mike Rapoport
2020-10-13 14:43 ` Randy Dunlap
2020-10-13 15:12 ` Mike Rapoport [this message]
2020-10-13 15:21 ` Randy Dunlap
2020-10-14 5:34 ` Mike Rapoport
2020-10-13 15:28 ` Muchun Song
2020-10-16 15:38 ` Vlastimil Babka
2020-10-16 20:53 ` Minchan Kim
2020-10-19 17:23 ` Shakeel Butt
2020-10-12 21:46 ` Cong Wang
2020-10-13 3:29 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013151215.GG4251@kernel.org \
--to=rppt@kernel$(echo .)org \
--cc=adobriyan@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=chenqiwu@xiaomi$(echo .)com \
--cc=christian.brauner@ubuntu$(echo .)com \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=daniel@iogearbox$(echo .)net \
--cc=dave@stgolabs$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=feng.tang@intel$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=guro@fb$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jakub@cloudflare$(echo .)com \
--cc=jannh@google$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=kafai@fb$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kirill.shutemov@linux$(echo .)intel.com \
--cc=kuba@kernel$(echo .)org \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linmiaohe@huawei$(echo .)com \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=mhocko@suse$(echo .)com \
--cc=minchan@kernel$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=mtk.manpages@gmail$(echo .)com \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=rafael@kernel$(echo .)org \
--cc=rdunlap@infradead$(echo .)org \
--cc=samitolvanen@google$(echo .)com \
--cc=shakeelb@google$(echo .)com \
--cc=songmuchun@bytedance$(echo .)com \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=walken@google$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=willemb@google$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox