From: Andrew Lunn <andrew@lunn•ch>
To: Robert Hancock <robert.hancock@calian•com>
Cc: "linux@armlinux•org.uk" <linux@armlinux•org.uk>,
"hkallweit1@gmail•com" <hkallweit1@gmail•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH] net: phy: marvell: add special handling of Finisar modules with 81E1111
Date: Mon, 19 Oct 2020 23:59:44 +0200 [thread overview]
Message-ID: <20201019215944.GZ139700@lunn.ch> (raw)
In-Reply-To: <e9214e305158b9b487862f89b7a88dd292beb824.camel@calian.com>
> I suppose that part would be pretty harmless, as you would likely want
> that behavior whenever that if condition was triggered. So
> m88e1111_finisar_config_init could likely be merged into
> m88e1111_config_init.
I think so as well.
> Mainly what stopped me from making all of these changes generic to all
> 88E1111 is that I'm a bit less confident in the different config_aneg
> behavior, it might be more specific to this SFP copper module case?
Well, for 1000BaseX, i don't think we currently have an SFP devices
using it, since phylink does not support it. So it is a question are
there any none-SFP m88e1111 out there you might break?
Andrew
next prev parent reply other threads:[~2020-10-19 21:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 20:49 [PATCH] net: phy: marvell: add special handling of Finisar modules with 81E1111 Robert Hancock
2020-10-19 21:00 ` Andrew Lunn
2020-10-19 21:43 ` Robert Hancock
2020-10-19 21:59 ` Andrew Lunn [this message]
2020-10-19 22:11 ` Robert Hancock
2020-10-19 21:06 ` Andrew Lunn
2020-10-19 21:09 ` Russell King - ARM Linux admin
2020-10-19 21:08 ` Russell King - ARM Linux admin
2020-10-19 21:32 ` Robert Hancock
2020-10-19 21:45 ` Andrew Lunn
2020-10-19 21:59 ` Robert Hancock
2020-10-19 22:12 ` Andrew Lunn
2020-10-19 22:21 ` Russell King - ARM Linux admin
2020-10-19 22:26 ` Robert Hancock
2020-10-19 22:03 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019215944.GZ139700@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robert.hancock@calian$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox