Subject: Re: [PATCH net] net: dsa: reference count the host mdb addresses

From: Andrew Lunn <[email-masked]>
Date: Tue, 20 Oct 2020 02:07:46 +0200

On Mon, Oct 19, 2020 at 04:55:14PM -0700, Jakub Kicinski wrote:
> On Fri, 16 Oct 2020 00:27:11 +0300 Vladimir Oltean wrote:
> > Currently any DSA switch that implements the multicast ops (properly,
> > that is) gets these errors after just sitting for a while, with at least
> > 2 ports bridged:
> > 
> > [  286.013814] mscc_felix 0000:00:00.5 swp3: failed (err=-2) to del object (id=3)
> > 
> > The reason has to do with this piece of code:
> > 
> > 	netdev_for_each_lower_dev(dev, lower_dev, iter)
> > 		br_mdb_switchdev_host_port(dev, lower_dev, mp, type);
> 
> We need a review on this one, anyone?

Hi Jakub

Thanks for the reminder. It has been on my TODO list since i got back
from vacation.

	Andrew