Subject: Re: [PATCH russell-kings-net-queue v2 2/3] net: phy: sfp: add support for multigig RollBall modules

From: Marek Behún <[email-masked]>
Date: Tue, 20 Oct 2020 18:14:38 +0200

On Tue, 20 Oct 2020 17:51:26 +0200
Andrew Lunn <[email-masked]> wrote:

> > @@ -2006,6 +2040,23 @@ static int sfp_sm_mod_probe(struct sfp *sfp, bool report)
> >  
> >  	sfp->id = id;
> >  
> > +	sfp->phy_addr = SFP_PHY_ADDR;
> > +
> > +	rollball = ((!memcmp(id.base.vendor_name, "OEM             ", 16) ||
> > +		     !memcmp(id.base.vendor_name, "Turris          ", 16)) &&
> > +		    (!memcmp(id.base.vendor_pn, "SFP-10G-T       ", 16) ||
> > +		     !memcmp(id.base.vendor_pn, "RTSFP-10", 8)));  
> 
> Are you customising the SFP, so that it has your vendor name?
> 
> Is the generic SFP OEM/SFP-10G-T, and your customized one Turris/ 
> RTSFP-10?
> 
> 	Andrew

Hilink puts OEM/SFP-10G-T into their modules.
RollBall puts OEM/RTSFP-10 and sometimes OEM/RTSFP-10G.
They are rebranding these modules for us to Turris/RTSFP-10.

Marek