From: Russell King - ARM Linux admin <linux@armlinux•org.uk>
To: Robert Hancock <robert.hancock@calian•com>
Cc: andrew@lunn•ch, hkallweit1@gmail•com, davem@davemloft•net,
netdev@vger•kernel.org
Subject: Re: [PATCH v3] net: phy: marvell: add special handling of Finisar modules with 88E1111
Date: Wed, 21 Oct 2020 10:31:00 +0100 [thread overview]
Message-ID: <20201021093100.GJ1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20201021001821.783249-1-robert.hancock@calian.com>
On Tue, Oct 20, 2020 at 06:18:21PM -0600, Robert Hancock wrote:
> The Finisar FCLF8520P2BTL 1000BaseT SFP module uses a Marvel 88E1111 PHY
> with a modified PHY ID. Add support for this ID using the 88E1111
> methods.
>
> By default these modules do not have 1000BaseX auto-negotiation enabled,
> which is not generally desirable with Linux networking drivers. Add
> handling to enable 1000BaseX auto-negotiation when these modules are
> used in 1000BaseX mode. Also, some special handling is required to ensure
> that 1000BaseT auto-negotiation is enabled properly when desired.
>
> Based on existing handling in the AMD xgbe driver and the information in
> the Finisar FAQ:
> https://www.finisar.com/sites/default/files/resources/an-2036_1000base-t_sfp_faqreve1.pdf
>
> Signed-off-by: Robert Hancock <robert.hancock@calian•com>
Reviewed-by: Russell King <rmk+kernel@armlinux•org.uk>
One minor issue remains - sorry I didn't spot it last time. Feel free
to fix that and retain the reviewed by above, no need for an immediate
v4 posting
Please resend when net-next is open, thanks.
> @@ -629,6 +632,51 @@ static int marvell_config_aneg_fiber(struct phy_device *phydev)
> return genphy_check_and_restart_aneg(phydev, changed);
> }
>
> +static int m88e1111_config_aneg(struct phy_device *phydev)
> +{
> + int err;
> + int extsr = phy_read(phydev, MII_M1111_PHY_EXT_SR);
This should be in reverse christmas tree order.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2020-10-21 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 0:18 [PATCH v3] net: phy: marvell: add special handling of Finisar modules with 88E1111 Robert Hancock
2020-10-21 9:31 ` Russell King - ARM Linux admin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021093100.GJ1551@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robert.hancock@calian$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox