Subject: Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push_eth actions

From: Stephen Hemminger <[email-masked]>
Date: Wed, 21 Oct 2020 11:32:34 -0700

On Mon, 19 Oct 2020 17:23:01 +0200
Guillaume Nault <[email-masked]> wrote:

> +		} else if (matches(*argv, "pop_eth") == 0) {

Using matches allows for shorter command lines but can be make
for bad user experience if strings overlap.

For example 'p' here will match the pop_eth and not the push_eth.

Is it time to use full string compare for these options?